Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable Codecov patch/project checks in CI/CD #664

Merged
merged 11 commits into from
Jul 10, 2024
Merged

Conversation

Splines
Copy link
Member

@Splines Splines commented Jul 8, 2024

Changes

  • We disable the patch/project checks of Codecov in our pipeline. I feel it's unrealistic that we will test everything. So Codecov helps us with a nice report in the comments of a PR. However, maybe we don't want the checks (e.g. you can't merge if you haven't tested every single Ruby line) to block us and instead only use them as information.
  • We move the .codecov.yml file back to the root of the repository. Unfortunately, the codecov_yml_path is buggy, see this issue: "Ignore paths" not working with custom Codecov config file location codecov/codecov-action#1465. Once that is resolved we may switch back to the new .config folder location. Having placed the config file into the root, Codecov now correctly reads the file and also ignores the spec folder. Note that the Codecov report is only generated once the test job was executed in GitHub Actions.

  • Docs for Codecov status checks.
  • Validity of schema checked via:
curl --data-binary @.codecov.yml https://codecov.io/validate

@Splines Splines added CI/CD Continuous Integration / Continuous Delivery (aka pipeline stuff) tests Unit tests, integration tests etc. labels Jul 8, 2024
@Splines Splines self-assigned this Jul 8, 2024
@Splines Splines changed the title Tests/codecov status checks Disable Codecov patch/project checks in CI/CD Jul 8, 2024
Copy link

codecov bot commented Jul 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.09%. Comparing base (6bde35d) to head (87f2ad2).

Additional details and impacted files
@@             Coverage Diff             @@
##              dev     #664       +/-   ##
===========================================
- Coverage   66.64%   53.09%   -13.55%     
===========================================
  Files         308      153      -155     
  Lines        9386     6614     -2772     
===========================================
- Hits         6255     3512     -2743     
+ Misses       3131     3102       -29     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Splines Splines merged commit bf7c6dc into dev Jul 10, 2024
8 checks passed
@Splines Splines deleted the tests/codecov-status-checks branch July 10, 2024 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/CD Continuous Integration / Continuous Delivery (aka pipeline stuff) tests Unit tests, integration tests etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants