Destroy talk media upon user deletion #651
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #647.
We noticed that destroying users by calling
destroy
directly (instead of calling thearchive_and_destroy
method) might result in invalid media as it has no editors anymore. From now on, we want to delete talk media of users when the respective user is destroyed under the following conditions:archive_and_destroy
-> STOP and don't do anythingOtherwise -> STOP and don't do anything (*)
(*) "Don't do anything" is just a safety measure. In the UserCleaner in #647, those users are considered to be non-generic, so we shouldn't call their
destroy
method in the first place.