Fix broken deletion of questions #640
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fosterfarrell9
changed the title
This comment was marked as off-topic.
This comment was marked as off-topic.
Splines
reviewed
May 22, 2024
There was a problem hiding this comment.
- On the questions/edit page, I'm still able to delete questions after the changes provided by you in this PR. But that also works locally even before your changes. Were you able to reproduce the error shown in Deletion of questions is broken #639 locally? I haven't found out how to do it yet.
- If only one question is left and I try to delete it, I get an error (before and after your change). But this is probably not related to this issue here and another bug, right?
Splines
approved these changes
May 27, 2024
There was a problem hiding this comment.
I missed that I have to delete the medium itself, not just one of its questions 🙈. I can now confirm that without the code change in this PR, we get the error discussed in #639. After the change, I could successfully delete media with a question that contains multiple answers, without encountering the "frozen hash literal" error again.
|
Use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #639 by removing the redundant
after_destroycallback in theMediummodel.