Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Rubocop version and enforce all cops #617

Merged
merged 5 commits into from
Apr 17, 2024
Merged

Update Rubocop version and enforce all cops #617

merged 5 commits into from
Apr 17, 2024

Commits on Apr 15, 2024

  1. Update Rubocop (and plugins) to latest versions

    @Splines
    Splines committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    e476bec View commit details
    Browse the repository at this point in the history

  2. Autocorrect safe cops 

    One rule was disabled since we don't want to alter already performed
migrations.
    @Splines
    Splines committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    c9c28fa View commit details
    Browse the repository at this point in the history

  3. Autocorrect unsafe cops 

    Special care is needed for `tag.rb` around line 190.
The autofix did not produce a valid result, I had to put extra
curly braces around that line as we want to push an object to the array.
    @Splines
    Splines committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    afccc70 View commit details
    Browse the repository at this point in the history

Commits on Apr 17, 2024

  1. Merge branch 'dev' into deps/update-rubocop

    @Splines
    Splines committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    9bed3a5 View commit details
    Browse the repository at this point in the history

  2. Remove unnecessary Unique validation RuboCop TODO 

    They probably got unnecessary due to the update of RuboCop, though I
haven't looked into their changelog to confirm.
    @Splines
    Splines committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    456239f View commit details
    Browse the repository at this point in the history