Fix ghost links in nested tabs #500
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## mampf-next #500 +/- ##
===========================================
Coverage 66.56% 66.56%
===========================================
Files 311 311
Lines 9376 9376
===========================================
Hits 6241 6241
Misses 3135 3135 |
|
still have to fix a small issue because I removed the
|
fosterfarrell9
approved these changes
May 11, 2023
|
no overlap anymore ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes Links in media card partial do not render properly #497
While viewing the media of a course, links were randomly placed and invisible (e.g. on the route:
http://localhost:3000/courses/2/edit). This was (mainly) due to a wrongly placed bootstrap classtab-contentinside a column layout (wrapping only one column instead of the whole row).