-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pipeline/e2e #453
Pipeline/e2e #453
Conversation
Codecov Report
@@ Coverage Diff @@
## mampf-next #453 +/- ##
==============================================
+ Coverage 65.44% 66.69% +1.25%
==============================================
Files 302 311 +9
Lines 8965 9350 +385
==============================================
+ Hits 5867 6236 +369
- Misses 3098 3114 +16
... and 4 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Could you also refine the name of the workflow/jobs, so that it's better readable in the overview? E.g. for the unit tests, we now get: You can do this by putting a We should also think of when we need to run this action, e.g. put something along these lines in the beginning of the compose file:
|
Ah nice, that's even better with no individual job name and only a global name in the docker compose file. Will do this for unit tests as well. Edit: I have overlooked that the name of the job ("build") is still present in the name. That's why I just changed the naming to align with that of the unit tests workflow file, i.e. general name before the "/", after that a bit more detailed job description. |
Integration tests are currently timing out with message:
|
@Splines found the bug, the test adapter env was set to I would fix the linter pipeline in a separate pull request. |
Ah wow, these are bugs we love, aren't they? 🙈😅 Thanks for fixing this.
What do you mean by that exactly? Is that the one force-push you made?
Awesome, had that in mind too, but if you tackle this, even better. I'm not that much of an CI/CD expert. |
I based the changes on
Increased. There are some tests that are failing (due to some weird checks based on CSS classes and recent changes in mampf-next), I will not address these here. |
This pull request is to be merged after #441 .
Upgrade cypress to 12 and fix the setup.
CI for e2e tests does not work.
no
no