Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI/CD Fix unit test workflow #441

Closed
wants to merge 33 commits into from
Closed

CI/CD Fix unit test workflow #441

wants to merge 33 commits into from

Commits on Mar 30, 2023

  1. Temporarily disable failing unit tests 

    Also renamed the GitHub workflow as its main purpose is to run the tests
(and not just creating the codecov report)
    @Splines
    Splines committed Mar 30, 2023
    Configuration menu
    Copy the full SHA
    89d0f35 View commit details
    Browse the repository at this point in the history

Commits on Mar 31, 2023

  1. Improve unit test workflow file 

    - Update checkout action to version v3
- Use new docker layer caching version
- Simplify commands to handle docker compose shell commands
- Update codecov action
    @Splines
    Splines committed Mar 31, 2023
    Configuration menu
    Copy the full SHA
    924f11d View commit details
    Browse the repository at this point in the history

  2. Ignore buildable images on docker compose pull 

    See docker/compose#8805
    @Splines
    Splines committed Mar 31, 2023
    Configuration menu
    Copy the full SHA
    ed93616 View commit details
    Browse the repository at this point in the history

Commits on Apr 10, 2023

  1. Revert "Temporarily disable failing unit tests" 

    (activate them again)

This reverts commit 89d0f35.
    @Splines
    Splines committed Apr 10, 2023
    Configuration menu
    Copy the full SHA
    5625d77 View commit details
    Browse the repository at this point in the history

  2. Fix failing unit tests by precompiling assets

    @Splines
    Splines committed Apr 10, 2023
    Configuration menu
    Copy the full SHA
    9f2e768 View commit details
    Browse the repository at this point in the history

Commits on Apr 11, 2023

  1. Run docker commands in new containers 

    (instead of using --detach)
    @Splines
    Splines committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    87d6ed6 View commit details
    Browse the repository at this point in the history

  2. Fix infinite GitHub actions running

    @Splines
    Splines committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    0919f81 View commit details
    Browse the repository at this point in the history

  3. Try to change order of rake tasks

    @Splines
    Splines committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    eeaf5c8 View commit details
    Browse the repository at this point in the history

  4. Try splitting rake tasks into two separate commands

    @Splines
    Splines committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    4a00816 View commit details
    Browse the repository at this point in the history

  5. Fix wrong indentation

    @Splines
    Splines committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    ed7cefb View commit details
    Browse the repository at this point in the history

  6. Run yarn install before assets:precompile 

    See https://www.digitalocean.com/community/questions/rails-deployment-failed-error-command-webpack-not-found?comment=174838

The gemfile is not altering the version, just using the previously
commented line.
    @Splines
    Splines committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    986842b View commit details
    Browse the repository at this point in the history

  7. Try out pipeline without docker caching

    @Splines
    Splines committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    5e158c5 View commit details
    Browse the repository at this point in the history

  8. Add webpacker as dev dependency 

    Instead of using "yarn install" (which installs all packages, also those
needed only in production)
    @Splines
    Splines committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    7c16b1d View commit details
    Browse the repository at this point in the history

  9. Let workflow timeout after 20min

    @Splines
    Splines committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    59a3383 View commit details
    Browse the repository at this point in the history

  10. Install frontend dev dependencies in docker

    @Splines
    Splines committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    3eaa756 View commit details
    Browse the repository at this point in the history

  11. Remove unnecessary dev dependencies

    @Splines
    Splines committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    dd16925 View commit details
    Browse the repository at this point in the history

  12. Remove unneeded packages in yarn lock 

    Cherry-picked from 71fc084
    @Splines
    Splines committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    6628197 View commit details
    Browse the repository at this point in the history

Commits on Apr 18, 2023

  1. Use docker compose file under run_tests folder

    @Splines
    Splines committed Apr 18, 2023
    Configuration menu
    Copy the full SHA
    1cd37f9 View commit details
    Browse the repository at this point in the history

  2. Try using rails CLI instead of rake

    @Splines
    Splines committed Apr 18, 2023
    Configuration menu
    Copy the full SHA
    380df26 View commit details
    Browse the repository at this point in the history

  3. Revert to rake CLI

    @Splines
    Splines committed Apr 18, 2023
    Configuration menu
    Copy the full SHA
    bbd305a View commit details
    Browse the repository at this point in the history

  4. Comment out entry point

    @Splines
    Splines committed Apr 18, 2023
    Configuration menu
    Copy the full SHA
    4927cca View commit details
    Browse the repository at this point in the history

  5. Revert dev Dockerfile yarn installation

    @Splines
    Splines committed Apr 18, 2023
    Configuration menu
    Copy the full SHA
    bbeb840 View commit details
    Browse the repository at this point in the history

  6. Explicitly install webpacker

    @Splines
    Splines committed Apr 18, 2023
    Configuration menu
    Copy the full SHA
    9e07799 View commit details
    Browse the repository at this point in the history

Commits on Apr 19, 2023

  1. Install yarn packages with docker for tests

    @Splines
    Splines committed Apr 19, 2023
    Configuration menu
    Copy the full SHA
    f55f848 View commit details
    Browse the repository at this point in the history

  2. Remove rake webpacker:install 

    (instead install yarn dependencies in Dockerfile)
    @Splines
    Splines committed Apr 19, 2023
    Configuration menu
    Copy the full SHA
    74fe6cc View commit details
    Browse the repository at this point in the history

  3. Explicitly use "yarn install" in Dockerfile

    @Splines
    Splines committed Apr 19, 2023
    Configuration menu
    Copy the full SHA
    1152257 View commit details
    Browse the repository at this point in the history

  4. Try again to also install webpacker via rake

    @Splines
    Splines committed Apr 19, 2023
    Configuration menu
    Copy the full SHA
    d892237 View commit details
    Browse the repository at this point in the history

Commits on Apr 21, 2023

  1. Upgrade Node to v20 for unit tests

    @Splines
    Splines committed Apr 21, 2023
    Configuration menu
    Copy the full SHA
    dfb1a61 View commit details
    Browse the repository at this point in the history

  2. Remove explicit "yarn install" in Dockerfile

    @Splines
    Splines committed Apr 21, 2023
    Configuration menu
    Copy the full SHA
    bf4c13c View commit details
    Browse the repository at this point in the history

  3. Run "bundle exec rails webpacker:install" in dockerfile 

    See installation instructions of official docs:
https://github.com/rails/webpacker/tree/5-x-stable#installation
    @Splines
    Splines committed Apr 21, 2023
    Configuration menu
    Copy the full SHA
    fc9fcd7 View commit details
    Browse the repository at this point in the history

  4. Use webpacker:compile in dockerfile

    @Splines
    Splines committed Apr 21, 2023
    Configuration menu
    Copy the full SHA
    5543196 View commit details
    Browse the repository at this point in the history

  5. Add yarn install before webpack install/compile

    @Splines
    Splines committed Apr 21, 2023
    Configuration menu
    Copy the full SHA
    db541f0 View commit details
    Browse the repository at this point in the history

  6. Use Node v18

    @Splines
    Splines committed Apr 21, 2023
    Configuration menu
    Copy the full SHA
    f395931 View commit details
    Browse the repository at this point in the history