Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor abilities #342

Merged
merged 32 commits into from
Mar 15, 2022
Merged

Refactor abilities #342

merged 32 commits into from
Mar 15, 2022

Conversation

fosterfarrell9
Copy link
Collaborator

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

Refactorisation

  • Please check if the PR fulfills these requirements
  • E2E Tests for the changes have been added via Cypress
  • Meaningful rspec tests have been added
  • Docs have been added / updated
  • What is the current behavior? (You can also link to an open issue here)

Authorization is done via ability.rb, which has become wy too big to be properly maintained.

  • What is the new behavior (if this is a feature change)?

abilities have been split up and placed in separate files in app/abilities

  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

  • Other information:

@cypress
Copy link

cypress bot commented Sep 23, 2021



Test summary

41 6 0 0Flakiness 3


Run details

Project MaMpf
Status Failed
Commit b44871c
Started Mar 3, 2022 5:31 PM
Ended Mar 3, 2022 5:44 PM
Duration 13:41 💡
OS Linux Debian - 10.10
Browser Electron 89

View run in Cypress Dashboard ➡️


Failures

courses_spec.js Failed
1 Courses > simple user > can not subscribe on page to unpublished
media_spec.js Failed
1 Media > Admin > can create medium & release it.
watchlists_spec.js Failed
1 Watchlists > User > can create and add to watchlist in lecture
2 Watchlists > User > can change watchlist
3 Watchlists > User > can view public watchlist of other user
4 Watchlists > User > can not view private watchlist of other user

Flakiness

media_spec.js Flakiness
1 Media > Non-Admin Teacher > can create medium & release it scheduled with submission
2 Media > Editor > can create medium & release it.
watchlists_spec.js Flakiness
1 Watchlists > User > can drag and drop watchlist_entry

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@fosterfarrell9 fosterfarrell9 marked this pull request as draft September 25, 2021 12:00
@codecov
Copy link

codecov bot commented Jan 7, 2022

Codecov Report

Merging #342 (b3b101f) into mampf-next (4441eab) will decrease coverage by 0.01%.
The diff coverage is 76.76%.

❗ Current head b3b101f differs from pull request most recent head 394c25a. Consider uploading reports for the commit 394c25a to get more accurate results

@@              Coverage Diff               @@
##           mampf-next     #342      +/-   ##
==============================================
- Coverage       65.98%   65.97%   -0.02%     
==============================================
  Files             301      301              
  Lines            8852     8969     +117     
==============================================
+ Hits             5841     5917      +76     
- Misses           3011     3052      +41     
Impacted Files Coverage Δ
app/models/lecture.rb 53.24% <0.00%> (+0.85%) ⬆️
app/models/medium.rb 45.65% <20.00%> (+0.47%) ⬆️
app/controllers/media_controller.rb 18.29% <25.00%> (+0.46%) ⬆️
app/controllers/tags_controller.rb 21.07% <25.00%> (-0.16%) ⬇️
app/controllers/chapters_controller.rb 30.76% <40.00%> (-0.49%) ⬇️
app/controllers/courses_controller.rb 34.21% <40.00%> (-0.52%) ⬇️
app/controllers/sections_controller.rb 29.50% <40.00%> (-0.32%) ⬇️
app/controllers/lessons_controller.rb 23.80% <42.85%> (-0.79%) ⬇️
app/controllers/main_controller.rb 42.42% <50.00%> (+0.48%) ⬆️
app/controllers/profile_controller.rb 23.42% <50.00%> (+0.99%) ⬆️
... and 24 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4441eab...394c25a. Read the comment docs.

@fosterfarrell9 fosterfarrell9 marked this pull request as ready for review March 3, 2022 17:08
@fosterfarrell9 fosterfarrell9 merged commit ec4eb78 into mampf-next Mar 15, 2022
@fosterfarrell9 fosterfarrell9 deleted the refactor_abilities branch March 15, 2022 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants