Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Laguna's team member names. #164

Open
Sebanisu opened this issue Mar 29, 2020 · 4 comments
Open

Laguna's team member names. #164

Sebanisu opened this issue Mar 29, 2020 · 4 comments
Labels
bug Something isn't working

Comments

@Sebanisu
Copy link
Collaborator

On save menu and battle menu Laguna's team member's names isn't populating.

@Sebanisu Sebanisu added the bug Something isn't working label Mar 29, 2020
@Sebanisu
Copy link
Collaborator Author

Should be an easy fix. Just querying the data wrong. They're odd because they use someone else's character data.

@Sebanisu
Copy link
Collaborator Author

One issue is TeamLaguna isn't set unless the game is loaded. So the load game menu will display the wrong value CharacterData isn't connected to the savedata. So values could be displayed wrong. I've corrected the name by not using the built in property. Though stats could be wrong if loading the wrong id from kernel.

@Sebanisu
Copy link
Collaborator Author

For load screen i'm bypassing the teamlaguna checks and going directly to the data. So level, character name and gold now should show correct values.

@Sebanisu
Copy link
Collaborator Author

Sebanisu commented Mar 30, 2020

most of this has been fixed. I restricted access to the character's dictionary. to prevent bypassing the team laguna checks and fixed partyPos so it isn't set to -1 when it can't find laguna in the party data list.

one bug remains that i saw which is when i load a save the data in the menu's isn't refreshed so names don't change etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant