Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for notice on $block['className'] #8

Open
ArnoSchneider opened this issue May 10, 2019 · 5 comments
Open

fix for notice on $block['className'] #8

ArnoSchneider opened this issue May 10, 2019 · 5 comments

Comments

@ArnoSchneider
Copy link

This should fix the notice on the undefined $block['className']

`
if(!empty($block['className'])):
$class_name = $block['className'] . ',';
else:
$class_name = false;
endif;

$block['classes'] = implode(' ', [$block['slug'], $class_name . 'align'.$block['align']]);

`

@mcnamee
Copy link

mcnamee commented Jul 31, 2019

@MWDelaney would you mind releasing a new release to Packagist?

@orditeck
Copy link

orditeck commented Jul 31, 2019

@mcnamee I did, feel free to use it if needed.

https://github.com/orditeck/sage9-acf-wp-blocks

@realcgslav
Copy link

realcgslav commented Jul 31, 2019

Second line:
$class_name = $block['className'] . ',';

should be:
$class_name = $block['className'] . ' ';

This comma is joining added additional classes. Space is working better ;)

@MWDelaney
Copy link
Owner

@MWDelaney would you mind releasing a new release to Packagist?

I plan to do this soon once I thoroughly test the newly merged PRs from today. In the meantime, if you set your composer version requirement to dev-master rather than a particular version number you'll get the latest master branch.

@lachieh
Copy link
Contributor

lachieh commented Oct 21, 2019

Any news here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants