Fix coordinate order for projection grids #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We nearly always use square grids so presumably didn't notice the incorrect order.
The grid is no longer square, does remapping with both remap_file and remap, and the first time index and top vertical level are selected from the input data for easier viz.
Test a non-square projection grid Update the reference files Remove redundant test for mpas_to_latlon Test more examples with remap_file (ncremap)
xylar
force-pushed
the
fix_projection_dim_order
branch
from
2d8bd0a
to
7df9f23
Compare
TestingI tested these fixes on a QU240wLI simulation with MPAS-Analysis. The corrected dimension order is handled fine, perhaps because MPAS-Analysis happens to always use square projection grids. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We nearly always use square grids so presumably didn't notice the incorrect order.
Update example with projection grid. The grid is no longer square, does remapping with both
remap_fileandremap, and the first time index and top vertical level are selected from the input data for easier viz.Update tests to handle fix to projection grids:
mpas_to_latlonremap_file(ncremap)