Fix non-standard declarations of 8-byte integers in ESMF_BaseMod.F90 #959
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ESMF_BaseMod module contains several non-standard declarations of 8-byte
integer variables. These were identified using the GNU compiler:
ESMF_BaseMod.F90:75:20:
75 | integer*8 :: ptr
| 1
Error: GNU Extension: Nonstandard type declaration INTEGER*8 at (1)
and also using the NAG compiler:
Error: ESMF_BaseMod.F90, line 75: KIND value (8) does not specify a valid representation method
Error: ESMF_BaseMod.F90, line 163: KIND value (8) does not specify a valid representation method
Since the ESMF_BaseMod module already defines a parameter for selecting 8-byte
integers, namely, ESMF_KIND_I8, all that is needed is to move the definition of
this (and related) parameters to appear earlier in the module and to then use
integer(kind=ESMF_KIND_I8)
rather than
integer(kind=8)
.
mark-petersen
added a commit
to E3SM-Project/E3SM
that referenced
this pull request
Mar 9, 2022
see MPAS-Dev/MPAS-Model#959 This PR fixes non-standard declarations of 8-byte integers in ESMF_BaseMod.F90. The ESMF_BaseMod module contains several non-standard declarations of 8-byte integer variables. These were identified using the GNU compiler: ESMF_BaseMod.F90:75:20: 75 | integer*8 :: ptr | 1 Error: GNU Extension: Nonstandard type declaration INTEGER*8 at (1) and also using the NAG compiler: Error: ESMF_BaseMod.F90, line 75: KIND value (8) does not specify a valid representation method Error: ESMF_BaseMod.F90, line 163: KIND value (8) does not specify a valid representation method Since the ESMF_BaseMod module already defines a parameter for selecting 8-byte integers, namely, ESMF_KIND_I8, all that is needed is to move the definition of this (and related) parameters to appear earlier in the module and to then use integer(kind=ESMF_KIND_I8) rather than integer(kind=8)
jonbob
added a commit
to E3SM-Project/E3SM
that referenced
this pull request
Mar 9, 2022
…#4825) Fix non-standard declarations of 8-byte integers in ESMF in MPAS-Framework This PR fixes non-standard declarations of 8-byte integers in ESMF_BaseMod.F90. See the original PR for MPAS at MPAS-Dev/MPAS-Model#959. The ESMF_BaseMod module contains several non- standard declarations of 8-byte integer variables. These were identified using the GNU and NAG compilers. [BFB]
jonbob
added a commit
to E3SM-Project/E3SM
that referenced
this pull request
Mar 10, 2022
Fix non-standard declarations of 8-byte integers in ESMF in MPAS-Framework This PR fixes non-standard declarations of 8-byte integers in ESMF_BaseMod.F90. See the original PR for MPAS at MPAS-Dev/MPAS-Model#959. The ESMF_BaseMod module contains several non- standard declarations of 8-byte integer variables. These were identified using the GNU and NAG compilers. [BFB]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes non-standard declarations of 8-byte integers in ESMF_BaseMod.F90.
The ESMF_BaseMod module contains several non-standard declarations of 8-byte
integer variables. These were identified using the GNU compiler:
and also using the NAG compiler:
Since the ESMF_BaseMod module already defines a parameter for selecting 8-byte
integers, namely, ESMF_KIND_I8, all that is needed is to move the definition of
this (and related) parameters to appear earlier in the module and to then use
rather than
.