-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gaspari_cohn: allow passing xr.DataArray #298
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #298 +/- ##
==========================================
+ Coverage 86.73% 86.79% +0.05%
==========================================
Files 38 38
Lines 1561 1568 +7
==========================================
+ Hits 1354 1361 +7
Misses 207 207
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
Obviously it does not matter a bit but I like the solution I found for supporting numpy arrays and |
… into gc_allow_dataarray
isort . && black . && flake8
CHANGELOG.rst
Allow passing
xr.DataArray
togaspari_cohn
. Maybe this needs a check such that noDataset
is passed? - Done.This was motivated by looking at #109 again.