return all orders regardless of the status #508
Conversation
|
My review is in progress 📖 - I will have feedback for you in a few minutes! |
![korbit-ai[bot]](https://github.com/avatars/in/322216?s=60&v=4){kind=small}
There was a problem hiding this comment.
I have reviewed your code and found 1 potential issue. To discuss my individual comments that I have added, tag me in replies using @korbit-ai.
Please react with a 👍 to my comments that you find helpful and a 👎 to those you find unhelpful - this will help me learn and improve as we collaborate.
| def _process_error_order(self, order, error): | ||
| self._new_orders.remove(order.identifier, key="identifier") | ||
| self._unprocessed_orders.remove(order.identifier, key="identifier") | ||
| self._partially_filled_orders.remove(order.identifier, key="identifier") | ||
| self._filled_orders.remove(order.identifier, key="identifier") | ||
| order.status = self.ERROR_ORDER | ||
| order.set_error(error) | ||
| self._error_orders.append(order) | ||
| return order |
There was a problem hiding this comment.
The _process_error_order method is handling error orders, but it is not providing any information about the error or alerting the caller that an error occurred. Consider adding logging statements or raising an exception to provide more visibility into error orders and potentially halt execution if necessary.
Description by Korbit AI
Note
This feature is in early access. You can enable or disable it in the Korbit Console.
What change is being made?
Add support for tracking and processing orders with an "error" status in the
lumibotlibrary.Why are these changes being made?
This change ensures that all orders, including those with errors, are tracked and processed correctly, providing a more comprehensive order management system. This addresses the issue of untracked error orders and improves the robustness of the order handling mechanism.