Removing cython dependency #168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
also adding some type hints and a generic numeric type
need to add some better tests not just 0 and 1s
not required, can be done using processor
same interpolator but this implementation uses numpy instead of cython
this means no more cython code
there is no real advantage to using a builder design pattern for loopstructural
this just makes it easier to scale scalar field between 0 and 1
…tural into dev-december-23
Fix/update docs navigation
required changing how fold interpolator is setup. Rather than initialising with a fold, the fold is added to the interpolator added map between stringinterpolator names and the interpolatortypes enum
…y chooses the second one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fairly major changes to the interpolation removing the requirement for cython by finding common faces for the tetrahedron. This approach works for both structured and unstructured tetra e.g. tetra defined by a cartesian grid and also tetra defined by elements, nodes and neighbours.