Skip to content
This repository has been archived by the owner on May 6, 2020. It is now read-only.

Any updates coming? #5

Open
ChristianKernDev opened this issue Feb 15, 2018 · 1 comment
Open

Any updates coming? #5

ChristianKernDev opened this issue Feb 15, 2018 · 1 comment

Comments

@ChristianKernDev
Copy link

Hey there i'm working on a discord bot atm and i would like to know if there is a newer version of the wrapper currently in work? I could also help if you want 😄

@LogicalOverflow
Copy link
Owner

LogicalOverflow commented Feb 21, 2018

I am currently busy with other things and can't really invest time in the project right now. To make the library usable for the current version of the API, the following has to be done:

  • The new objects, representing the JSON data returned by the API must be created (here)
  • The new API methods must be added to the retrofit interface (ChampionGGAPI.java).
  • There might be new error responses which need adding (here)
  • New test cases with the new responses must be added. This includes adding any new parameters the API has in this function here as well as collecting the test responses in JSON files here
  • Everything deprecated needs to be removed in the areas above

If you, or anyone else for that matter, has the time and will to do this, feel free to do so and create a pull request.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants