Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

Update jsonargparse[signatures] requirement from <=4.9.0,>4.0.0 to >4.0.0,<=4.21.1 in /requirements #1564

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github May 29, 2023

Updates the requirements on jsonargparse[signatures] to permit the latest version.

Changelog

Sourced from jsonargparse[signatures]'s changelog.

v4.21.1 (2023-05-09)

Fixed ^^^^^

  • AST resolver not working for dict used in a method when the dict is created using the curly braces syntax.
  • Failure on multiple deep arguments linked on instantiation ([#275](https://github.com/omni-us/jsonargparse/issues/275) <https://github.com/omni-us/jsonargparse/issues/275>__).

v4.21.0 (2023-04-21)

Added ^^^^^

  • Support for dataclasses nested in a type ([#243](https://github.com/omni-us/jsonargparse/issues/243) <https://github.com/omni-us/jsonargparse/issues/243>__).
  • Support for pydantic models <https://docs.pydantic.dev/usage/models/>__ and attrs define <https://www.attrs.org/en/stable/examples.html>__ similar to dataclasses.
  • Support for pydantic types <https://docs.pydantic.dev/usage/types/#pydantic-types>__.
  • Backport type stubs in python<=3.9 to support PEP 585 <https://peps.python.org/pep-0585/>__ and 604 <https://peps.python.org/pep-0604/>__ syntax.

Fixed ^^^^^

  • str parameter in subclass incorrectly parsed as dict with implicit null value ([#262](https://github.com/omni-us/jsonargparse/issues/262) <https://github.com/omni-us/jsonargparse/issues/262>__).
  • Wrong error indentation for subclass in union (lightning#17254 <https://github.com/Lightning-AI/lightning/issues/17254>__).
  • dataclass from pydantic not working ([#100](https://github.com/omni-us/jsonargparse/issues/100) comment <https://github.com/omni-us/jsonargparse/issues/100#issuecomment-1408413796>__).
  • add_dataclass_arguments not forwarding sub_configs parameter.
  • Failure to instantiate nested class group without arguments (lightning#17263 <https://github.com/Lightning-AI/lightning/issues/17263>__).

Changed ^^^^^^^

  • Switched from setup.cfg to pyproject.toml for configuration.
  • Removed build_sphinx from setup.py and documented how to build.
  • Include enum members in error when invalid value is given (lightning#17247 <https://github.com/Lightning-AI/lightning/issues/17247>__).
  • The signatures extras now installs the typing-extensions package on python<=3.9.
  • CLI now when given a class without methods, the class instance is returned.

... (truncated)

Commits
  • 0942fb9 Bump version: 4.21.0 → 4.21.1
  • 677a0f9 [pre-commit.ci] auto fixes from pre-commit.com hooks
  • 37e9cbf Refactored util tests using pytest.
  • f3f74d1 adding black formatting (#279)
  • 1c303a6 Fixed failure on multiple deep arguments linked on instantiation (#275).
  • d7e6dde add Ruff as code check (#280)
  • 8d57577 Refactored loaders_dumpers, namespace and optionals tests using pytest.
  • 54bf840 Refactored formatters, jsonschema and jsonnet tests using pytest.
  • 0805435 Refactored actions, argcomplete and cli tests using pytest.
  • 9039750 Removed some unittest specific code.
  • Additional commits viewable in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added the enhancement New feature or request label May 29, 2023
@dependabot dependabot bot requested a review from a team May 29, 2023 16:41
@Borda Borda enabled auto-merge (squash) May 29, 2023 18:10
@Borda
Copy link
Member

Borda commented May 29, 2023

@dependabot rebase

Updates the requirements on [jsonargparse[signatures]](https://github.com/omni-us/jsonargparse) to permit the latest version.
- [Changelog](https://github.com/omni-us/jsonargparse/blob/master/CHANGELOG.rst)
- [Commits](omni-us/jsonargparse@v4.0.1...v4.21.1)

---
updated-dependencies:
- dependency-name: jsonargparse[signatures]
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot-pip-requirements-jsonargparse-signatures--gt-4.0.0-and-lte-4.21.1 branch from cae679a to cb27718 Compare May 29, 2023 18:10
@Borda Borda disabled auto-merge May 29, 2023 19:28
@Borda Borda enabled auto-merge (squash) May 29, 2023 19:33
@codecov
Copy link

codecov bot commented May 29, 2023

Codecov Report

Merging #1564 (0f0bde6) into master (84e5e1d) will decrease coverage by 18%.
The diff coverage is 100%.

❗ Current head 0f0bde6 differs from pull request most recent head 340d57c. Consider uploading reports for the commit 340d57c to get more accurate results

Additional details and impacted files
@@           Coverage Diff            @@
##           master   #1564     +/-   ##
========================================
- Coverage      86%     68%    -18%     
========================================
  Files         291     291             
  Lines       12874   12865      -9     
========================================
- Hits        11011    8731   -2280     
- Misses       1863    4134   +2271     

@Borda
Copy link
Member

Borda commented Jun 5, 2023

@mauvilsa could you pls advise how best to resolve this issue in the latest jsonargparse? 🐰

try:
from jsonargparse.signatures import ClassFromFunctionBase
except ImportError:
from jsonargparse.util import ClassFromFunctionBase
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The error that I see in the tests are because the function class_from_function has been duplicated here, and now differs. Note the missing line util.py#L384. Would be better if the code is not duplicated to avoid this kind of problems. For now, adding the missing line should fix the problem.

Note that neither ClassFromFunctionBase nor ClassType are supposed to be public. And I plan to change the modules so that they start with _ and be more explicit on what is not public, see https://github.com/orgs/omni-us/projects/1. So this will need to be fixed again.

@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Jun 12, 2023

A newer version of jsonargparse[signatures] exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged.

@Borda Borda marked this pull request as draft June 20, 2023 10:06
auto-merge was automatically disabled June 20, 2023 10:06

Pull request was converted to draft

@Borda Borda closed this in #1620 Jun 27, 2023
@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Jun 27, 2023

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@dependabot dependabot bot deleted the dependabot-pip-requirements-jsonargparse-signatures--gt-4.0.0-and-lte-4.21.1 branch June 27, 2023 07:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants