-
Notifications
You must be signed in to change notification settings - Fork 213
Update jsonargparse[signatures] requirement from <=4.9.0,>4.0.0 to >4.0.0,<=4.21.1 in /requirements #1564
Conversation
@dependabot rebase |
Updates the requirements on [jsonargparse[signatures]](https://github.com/omni-us/jsonargparse) to permit the latest version. - [Changelog](https://github.com/omni-us/jsonargparse/blob/master/CHANGELOG.rst) - [Commits](omni-us/jsonargparse@v4.0.1...v4.21.1) --- updated-dependencies: - dependency-name: jsonargparse[signatures] dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
cae679a
to
cb27718
Compare
for more information, see https://pre-commit.ci
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #1564 +/- ##
========================================
- Coverage 86% 68% -18%
========================================
Files 291 291
Lines 12874 12865 -9
========================================
- Hits 11011 8731 -2280
- Misses 1863 4134 +2271 |
@mauvilsa could you pls advise how best to resolve this issue in the latest |
try: | ||
from jsonargparse.signatures import ClassFromFunctionBase | ||
except ImportError: | ||
from jsonargparse.util import ClassFromFunctionBase |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The error that I see in the tests are because the function class_from_function
has been duplicated here, and now differs. Note the missing line util.py#L384. Would be better if the code is not duplicated to avoid this kind of problems. For now, adding the missing line should fix the problem.
Note that neither ClassFromFunctionBase
nor ClassType
are supposed to be public. And I plan to change the modules so that they start with _
and be more explicit on what is not public, see https://github.com/orgs/omni-us/projects/1. So this will need to be fixed again.
…ignatures--gt-4.0.0-and-lte-4.21.1
A newer version of jsonargparse[signatures] exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged. |
…ignatures--gt-4.0.0-and-lte-4.21.1
Pull request was converted to draft
OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting If you change your mind, just re-open this PR and I'll resolve any conflicts on it. |
Updates the requirements on jsonargparse[signatures] to permit the latest version.
Changelog
Sourced from jsonargparse[signatures]'s changelog.
... (truncated)
Commits
0942fb9
Bump version: 4.21.0 → 4.21.1677a0f9
[pre-commit.ci] auto fixes from pre-commit.com hooks37e9cbf
Refactored util tests using pytest.f3f74d1
adding black formatting (#279)1c303a6
Fixed failure on multiple deep arguments linked on instantiation (#275).d7e6dde
add Ruff as code check (#280)8d57577
Refactored loaders_dumpers, namespace and optionals tests using pytest.54bf840
Refactored formatters, jsonschema and jsonnet tests using pytest.0805435
Refactored actions, argcomplete and cli tests using pytest.9039750
Removed some unittest specific code.Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)