Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix & extend StrEnum.from_str #99

Merged
merged 7 commits into from
Feb 7, 2023
Merged

fix & extend StrEnum.from_str #99

merged 7 commits into from
Feb 7, 2023

Conversation

Borda
Copy link
Member

@Borda Borda commented Feb 7, 2023

Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did all existing and newly added tests pas locally?

What does this PR do?

While extending, I found a bug that source="key" was not followed correctly
the idea coming from: Lightning-AI/torchmetrics#1474 (comment)

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in GitHub issues there's a high chance it will not be merged.

@Borda Borda added bug Something isn't working enhancement New feature or request labels Feb 7, 2023
@Borda Borda enabled auto-merge (squash) February 7, 2023 06:50
CHANGELOG.md Outdated Show resolved Hide resolved
@Borda Borda disabled auto-merge February 7, 2023 12:22
@Borda Borda merged commit b76c85a into main Feb 7, 2023
@Borda Borda deleted the feat/enum branch February 7, 2023 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants