Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing cannot import name 'metadata' from 'importlib' #65

Merged
merged 14 commits into from
Oct 31, 2022
Merged

Conversation

Borda
Copy link
Member

@Borda Borda commented Oct 31, 2022

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

What does this PR do?

There are several issues while porting the latest 0.4.0 on py3.7
https://github.com/Lightning-AI/lightning-bolts/actions/runs/3360908680/jobs/5570659384

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@Borda Borda added bug Something isn't working priority: 0 High priority task labels Oct 31, 2022
@Borda Borda marked this pull request as draft October 31, 2022 12:52
@Borda Borda marked this pull request as ready for review October 31, 2022 13:36
@Borda Borda enabled auto-merge (squash) October 31, 2022 13:37
@Borda Borda requested a review from otaj October 31, 2022 13:44
requirements/test.txt Outdated Show resolved Hide resolved
Copy link
Contributor

@akihironitta akihironitta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Borda Borda merged commit cdedd59 into main Oct 31, 2022
@Borda Borda deleted the ci/metadata branch October 31, 2022 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working priority: 0 High priority task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants