Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix calling actions in external re-usable workflows #51

Merged
merged 4 commits into from
Dec 24, 2022
Merged

Conversation

Borda
Copy link
Member

@Borda Borda commented Sep 14, 2022

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

What does this PR do?

Seems that this local reference is a limiting factor when you call it from external repo
see: https://github.com/Lightning-AI/lightning-sandbox/actions/runs/3054734233/jobs/4926989948

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@Borda Borda added the bug Something isn't working label Sep 14, 2022
@Borda
Copy link
Member Author

Borda commented Sep 14, 2022

Seem this is tricky as this asks for a specific version, so for development, we would like to have here main but for external users the same version and the used workflow... 🐰

@Borda Borda self-assigned this Sep 14, 2022
@Borda Borda added the priority: 0 High priority task label Sep 14, 2022
@Borda
Copy link
Member Author

Borda commented Dec 5, 2022

not sure what to do here and don't see any useful docs to solve this as what we want is pinning the action with the same tag as the workflow release... so as to make another extra commit just before making tags freezing internal actions... 🦦

@Borda Borda closed this Dec 5, 2022
@Borda Borda deleted the ci/actions branch December 19, 2022 10:23
@Borda
Copy link
Member Author

Borda commented Dec 19, 2022

@Borda Borda mentioned this pull request Dec 24, 2022
4 tasks
@Borda Borda changed the title fix using actions for external fix calling actions in external re-usable workflows Dec 24, 2022
@Borda Borda merged commit 79ec5f6 into main Dec 24, 2022
@Borda Borda deleted the ci/actions branch December 24, 2022 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working priority: 0 High priority task
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants