Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

script/adjust: preserve all comments in requirements #178

Merged
merged 38 commits into from
Oct 10, 2023
Merged

script/adjust: preserve all comments in requirements #178

merged 38 commits into from
Oct 10, 2023

Conversation

Borda
Copy link
Member

@Borda Borda commented Oct 9, 2023

Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did all existing and newly added tests pass locally?

What does this PR do?

When we ran the adjusted version in our CI, it removed all comments (also # strict directive), which yielded wrongly preserving upper bounds...

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in GitHub issues, there's a high chance it will not be merged.

@Borda Borda added bug Something isn't working priority: 1 Medium priority task labels Oct 9, 2023
@Borda Borda enabled auto-merge (squash) October 9, 2023 18:55
awaelchli
awaelchli reviewed Oct 9, 2023
View reviewed changes
Copy link
Contributor

@awaelchli awaelchli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest that we make a unit test case for this

@github-actions github-actions bot added the ci/cd Continuous integration and delivery label Oct 10, 2023
@Borda
Copy link
Member Author

Borda commented Oct 10, 2023 •
edited
Loading

Damm windows has a line ending that I am not bale to drop, so the final replacement has empty line after each normal line... 😿

@Borda Borda requested a review from awaelchli October 10, 2023 08:42
@Borda Borda merged commit 68ebf4b into main Oct 10, 2023
34 checks passed
@Borda Borda deleted the script/adjust-coments branch October 10, 2023 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@awaelchli awaelchli awaelchli approved these changes

@carmocca carmocca Awaiting requested review from carmocca

Assignees
No one assigned
Labels
bug Something isn't working ci/cd Continuous integration and delivery priority: 1 Medium priority task
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Borda @awaelchli