Skip to content

Commit

Permalink
ci: enable custom env. vars in pkg check (#317)
Browse files Browse the repository at this point in the history
  • Loading branch information
Borda authored Oct 15, 2024
1 parent bc73cee commit 39675b7
Show file tree
Hide file tree
Showing 3 changed files with 12 additions and 2 deletions.
10 changes: 10 additions & 0 deletions .github/workflows/check-package.yml
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,14 @@ on:
"os": ["ubuntu-20.04", "macos-11", "windows-2022"],
"python-version": ["3.8", "3.9"]
}
env-vars:
description: "custom environment variables in json format"
required: false
type: string
default: |
{
"SAMPLE_ENV_VARIABLE": 1,
}
defaults:
run:
Expand All @@ -73,6 +81,7 @@ jobs:
pkg-build:
needs: init-store
runs-on: ${{ matrix.os }}
env: ${{ fromJSON(inputs.env-vars) }}
strategy:
max-parallel: 1 # run sequential to prevent download/upload collisions
fail-fast: false
Expand Down Expand Up @@ -104,6 +113,7 @@ jobs:
pkg-check:
needs: pkg-build
runs-on: ${{ matrix.os }}
env: ${{ fromJSON(inputs.env-vars) }}
strategy:
fail-fast: false
matrix: ${{ fromJSON(inputs.testing-matrix) }}
Expand Down
2 changes: 1 addition & 1 deletion .pre-commit-config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ repos:
#args: ["--write-changes"] # uncomment if you want to get automatic fixing

- repo: https://github.com/PyCQA/docformatter
rev: v1.7.5
rev: 06907d0267368b49b9180eed423fae5697c1e909 # todo: fix for docformatter after last 1.7.5
hooks:
- id: docformatter
additional_dependencies: [tomli]
Expand Down
2 changes: 1 addition & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

### Changed

-
- CI: enable custom env. vars in pkg check workflow ([#317](https://github.com/Lightning-AI/utilities/pull/317))

### Fixed

Expand Down

0 comments on commit 39675b7

Please sign in to comment.