Recompute SDR in float64 type if float32 gives NaN or Inf #899
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quancs
requested review from
Borda,
SkafteNicki,
justusschock,
tchaton,
ethanwharris and
SeanNaren
as code owners
for more information, see https://pre-commit.ci
Codecov Report
@@ Coverage Diff @@
## master #899 +/- ##
=====================================
Coverage 95% 95%
=====================================
Files 173 173
Lines 7237 7241 +4
=====================================
+ Hits 6857 6878 +21
+ Misses 380 363 -17 |
quancs
changed the title
Borda
reviewed
Mar 22, 2022
OK |
SkafteNicki
reviewed
Mar 22, 2022
Co-authored-by: Nicki Skafte Detlefsen <skaftenicki@gmail.com>
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Borda
reviewed
Mar 22, 2022
|
As discussed offline with @Borda , the audio examples will be moved to s3 to remove them from git. |
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
Borda
approved these changes
Mar 22, 2022
SkafteNicki
approved these changes
Mar 22, 2022
justusschock
approved these changes
Mar 22, 2022
Borda
pushed a commit
that referenced
this pull request
Mar 23, 2022
* fixing issue * add test for issue 895 * Apply suggestions from code review * data Co-authored-by: quancs <quancs@qq.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Nicki Skafte Detlefsen <skaftenicki@gmail.com> Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com> Co-authored-by: Jirka <jirka.borovec@seznam.cz> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> (cherry picked from commit 61ea070)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #895
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃