Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds new image metric - d_lambda #873

Merged
merged 41 commits into from
Apr 11, 2022

Conversation

ankitaS11
Copy link
Contributor

@ankitaS11 ankitaS11 commented Mar 6, 2022

Please see the previous PR here which was accidentally closed (the repo got deleted...).

What does this PR do?

Adds New Image Metric - D_Lambda (Spectral Distortion Index)

Fixes a part of #799

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@ankitaS11 ankitaS11 marked this pull request as draft March 6, 2022 15:56
@ankitaS11 ankitaS11 marked this pull request as ready for review March 6, 2022 18:11
@codecov
Copy link

codecov bot commented Mar 6, 2022

Codecov Report

Merging #873 (70c4995) into master (97f2bf5) will increase coverage by 0%.
The diff coverage is 97%.

@@          Coverage Diff          @@
##           master   #873   +/-   ##
=====================================
  Coverage      95%    95%           
=====================================
  Files         173    175    +2     
  Lines        7401   7468   +67     
=====================================
+ Hits         7029   7094   +65     
- Misses        372    374    +2     

Copy link
Contributor

@stancld stancld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor comments, otherwise LGTM already from #855

CHANGELOG.md Outdated Show resolved Hide resolved
tests/image/test_d_lambda.py Outdated Show resolved Hide resolved
torchmetrics/functional/image/d_lambda.py Outdated Show resolved Hide resolved
torchmetrics/functional/image/d_lambda.py Outdated Show resolved Hide resolved
torchmetrics/image/d_lambda.py Outdated Show resolved Hide resolved
torchmetrics/functional/image/d_lambda.py Show resolved Hide resolved
torchmetrics/image/d_lambda.py Show resolved Hide resolved
@mergify mergify bot added the ready label Mar 6, 2022
ankitaS11 and others added 5 commits March 7, 2022 00:44
Co-authored-by: Daniel Stancl <46073029+stancld@users.noreply.github.com>
Co-authored-by: Daniel Stancl <46073029+stancld@users.noreply.github.com>
Co-authored-by: Daniel Stancl <46073029+stancld@users.noreply.github.com>
Co-authored-by: Daniel Stancl <46073029+stancld@users.noreply.github.com>
Co-authored-by: Daniel Stancl <46073029+stancld@users.noreply.github.com>
@mergify mergify bot removed the ready label Mar 6, 2022
ankitaS11 and others added 3 commits April 4, 2022 23:33
Co-authored-by: Daniel Stancl <46073029+stancld@users.noreply.github.com>
@Borda Borda modified the milestones: v0.8, v0.9 Apr 5, 2022
@Borda
Copy link
Member

Borda commented Apr 8, 2022

@SkafteNicki @justusschock pls ^^

@mergify mergify bot added the ready label Apr 8, 2022
Copy link
Member

@SkafteNicki SkafteNicki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few commets, else LGTM

tests/image/test_d_lambda.py Outdated Show resolved Hide resolved
tests/image/test_d_lambda.py Outdated Show resolved Hide resolved
torchmetrics/functional/image/d_lambda.py Outdated Show resolved Hide resolved
torchmetrics/image/d_lambda.py Outdated Show resolved Hide resolved
torchmetrics/image/d_lambda.py Outdated Show resolved Hide resolved
torchmetrics/image/d_lambda.py Outdated Show resolved Hide resolved
torchmetrics/image/d_lambda.py Outdated Show resolved Hide resolved
torchmetrics/image/d_lambda.py Outdated Show resolved Hide resolved
ankitaS11 and others added 2 commits April 10, 2022 20:07
Co-authored-by: Nicki Skafte Detlefsen <skaftenicki@gmail.com>
@ankitaS11
Copy link
Contributor Author

Few commets, else LGTM

Hi @SkafteNicki, I have updated the branch, please take a look again whenever you have the time :)

Copy link
Member

@SkafteNicki SkafteNicki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

final comments (just for consistency in naming)

torchmetrics/functional/image/d_lambda.py Outdated Show resolved Hide resolved
torchmetrics/functional/image/d_lambda.py Outdated Show resolved Hide resolved
torchmetrics/functional/image/d_lambda.py Outdated Show resolved Hide resolved
torchmetrics/functional/image/d_lambda.py Outdated Show resolved Hide resolved
torchmetrics/image/d_lambda.py Outdated Show resolved Hide resolved
torchmetrics/image/d_lambda.py Outdated Show resolved Hide resolved
torchmetrics/image/d_lambda.py Outdated Show resolved Hide resolved
@mergify mergify bot removed the ready label Apr 11, 2022
@Borda Borda enabled auto-merge (squash) April 11, 2022 07:57
@Borda Borda merged commit d587be9 into Lightning-AI:master Apr 11, 2022
@mergify mergify bot added the ready label Apr 11, 2022
@Borda Borda modified the milestones: v0.9, v0.8 Apr 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants