-
Notifications
You must be signed in to change notification settings - Fork 404
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: default py3.8 #689
CI: default py3.8 #689
Conversation
Codecov Report
@@ Coverage Diff @@
## master #689 +/- ##
=====================================
Coverage 94% 94%
=====================================
Files 182 182
Lines 8147 8147
=====================================
Hits 7654 7654
Misses 493 493 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can only use python 3.9!
Torch Binaries are not yet available for 3.10 (neither on pypi nor on https://download.pytorch.org/whl/cpu/torch_stable.html)
yep, I found it too, so this will hang tll they start supporting it :] otherwise, this PR does not make much sense if we still keep 3.9 as the latest python and the PR is called add 3.10 support :] |
no need, it is blocked on its own by CI tests
3a0f7dc
to
317182c
Compare
with running the
|
seem #949 would be a very needed update for this case |
now it fails to build the |
as py3.10 was added in #1132 let's just set default py3.8 |
What does this PR do?
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃