-
Notifications
You must be signed in to change notification settings - Fork 404
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Word Information Lost and Preserved - ASR metrics #630
Conversation
Word Information Lost and Preserved - metrics for ASR
for more information, see https://pre-commit.ci
Codecov Report
@@ Coverage Diff @@
## master #630 +/- ##
=====================================
Coverage 95% 95%
=====================================
Files 155 160 +5
Lines 5513 5597 +84
=====================================
+ Hits 5246 5326 +80
- Misses 267 271 +4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not much to comment here, PR looks very good.
Please refactor the _edit_distance
into its own file to reduce duplicates.
Co-authored-by: Nicki Skafte Detlefsen <skaftenicki@gmail.com>
Co-authored-by: Nicki Skafte Detlefsen <skaftenicki@gmail.com>
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM :]
@stancld could you take a look? |
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Except for two minor comments regarding the inappropriate docstrings, LGTM! :]
Co-authored-by: Daniel Stancl <46073029+stancld@users.noreply.github.com>
Head branch was pushed to by a user without write access
Word Information Lost and Preserved - metrics for ASR
What does this PR do?
Fixes #<issue_number>
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃