-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Replace grad norm. try to fix TPU dataloader issue #949
Conversation
Hello @srush! Thanks for opening this PR.
Do see the Hitchhiker's guide to code style |
@dlibenzi nope! is that the issue? |
Yep, that's the issue 😉 |
I think I found it #957 |
Yes... fixed! @srush make this PR only about the gradnorm? |
Check out the video of it working :) https://twitter.com/PyTorchLightnin/status/1232813118507692033?s=20 |
Awesome! Closing this guy. Switching to #959 |
Still playing around with TPU. I can now train one epoch fast, but when I start the second epoch it just ends with no error. Trying to figure out why that could be:
It seems to be something about this:
pytorch/xla#1191
Not sure if TPU dataloaders need to be specifically restarted?