-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix docs for early stopping #865
Fix docs for early stopping #865
Conversation
docs/source/early_stopping.rst
Outdated
---------------------- | ||
By default training will go with early stopping if there is | ||
`'val_loss'` in `validation_end()` return dict. Otherwise | ||
training will go with disabled early stopping. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it might be more clear to say "Otherwise training will proceed with early stopping disabled."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kuynzereb could you pls rephrase it, otherwise, it is good...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I have already changed it. Please look at the latest changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we shall use examples when it demonstrate some workflow or behaviour
the failing test was fixed in #873, pls rebase master |
26f3518
to
d0e67c0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
Updated docs for early stopping callback. Fixes #857.