Fix docs for early stopping #865
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
docs/source/early_stopping.rst
Outdated
| ---------------------- | ||
| By default training will go with early stopping if there is | ||
| `'val_loss'` in `validation_end()` return dict. Otherwise | ||
| training will go with disabled early stopping. |
There was a problem hiding this comment.
it might be more clear to say "Otherwise training will proceed with early stopping disabled."
There was a problem hiding this comment.
@kuynzereb could you pls rephrase it, otherwise, it is good...
There was a problem hiding this comment.
Yeah, I have already changed it. Please look at the latest changes.
Borda
requested changes
Feb 16, 2020
|
the failing test was fixed in #873, pls rebase master |
kuynzereb
force-pushed
the
fix_early_stopping_docs
branch
from
26f3518
to
d0e67c0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated docs for early stopping callback. Fixes #857.