Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add periods for the documentation #8252

Merged
merged 1 commit into from
Jul 2, 2021
Merged

Conversation

shirayu
Copy link
Contributor

@shirayu shirayu commented Jul 2, 2021

What does this PR do?

Improve document formatting.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

@shirayu shirayu marked this pull request as ready for review July 2, 2021 03:30
@codecov
Copy link

codecov bot commented Jul 2, 2021

Codecov Report

Merging #8252 (7656520) into master (365a9ba) will decrease coverage by 0%.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master   #8252   +/-   ##
======================================
- Coverage      88%     88%   -0%     
======================================
  Files         212     212           
  Lines       13701   13701           
======================================
- Hits        12125   12058   -67     
- Misses       1576    1643   +67     

@carmocca carmocca added the docs Documentation related label Jul 2, 2021
@carmocca carmocca added this to the v1.4 milestone Jul 2, 2021
@carmocca carmocca enabled auto-merge (squash) July 2, 2021 14:48
@carmocca carmocca merged commit 8193bae into Lightning-AI:master Jul 2, 2021
@shirayu shirayu deleted the patch-1 branch July 2, 2021 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants