Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move result teardown to loops #8245

Merged
merged 9 commits into from
Jul 2, 2021
Merged

Conversation

carmocca
Copy link
Contributor

@carmocca carmocca commented Jul 1, 2021

What does this PR do?

See title.

This was added to the LoggerConnector first because the loops weren't finished yet.

The Loops base implementation has been changed so teardown is not called every run call as we don't want to teardown every time run finishes for the smaller granularity loops.

Part of #7938
Includes #8250

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • [n/a] Did you make sure to update the documentation with your changes? (if necessary)
  • [n/a] Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

@carmocca carmocca added this to the v1.4 milestone Jul 1, 2021
@carmocca carmocca self-assigned this Jul 1, 2021
@codecov
Copy link

codecov bot commented Jul 1, 2021

Codecov Report

Merging #8245 (9cb2892) into master (8a7f504) will increase coverage by 0%.
The diff coverage is 100%.

@@          Coverage Diff           @@
##           master   #8245   +/-   ##
======================================
  Coverage      92%     92%           
======================================
  Files         212     212           
  Lines       13707   13709    +2     
======================================
+ Hits        12670   12672    +2     
  Misses       1037    1037           

CHANGELOG.md Show resolved Hide resolved
@carmocca carmocca marked this pull request as draft July 1, 2021 18:53
@carmocca carmocca marked this pull request as ready for review July 2, 2021 00:54
@awaelchli awaelchli self-requested a review July 2, 2021 02:08
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@tchaton tchaton merged commit 0e19d16 into master Jul 2, 2021
@tchaton tchaton deleted the refactor/move-result-teardown-to-loops branch July 2, 2021 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants