-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move result teardown to loops #8245
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carmocca
requested review from
awaelchli,
justusschock,
tchaton and
williamFalcon
as code owners
July 1, 2021 17:56
carmocca
commented
Jul 1, 2021
Codecov Report
@@ Coverage Diff @@
## master #8245 +/- ##
======================================
Coverage 92% 92%
======================================
Files 212 212
Lines 13707 13709 +2
======================================
+ Hits 12670 12672 +2
Misses 1037 1037 |
14 tasks
tchaton
reviewed
Jul 1, 2021
awaelchli
approved these changes
Jul 1, 2021
10 tasks
justusschock
approved these changes
Jul 2, 2021
awaelchli
approved these changes
Jul 2, 2021
tchaton
approved these changes
Jul 2, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM !
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
See title.
This was added to the
LoggerConnector
first because the loops weren't finished yet.The Loops base implementation has been changed so
teardown
is not called everyrun
call as we don't want to teardown every timerun
finishes for the smaller granularity loops.Part of #7938
Includes #8250
Before submitting
PR review