Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update Loggers #818

Merged
merged 2 commits into from
Feb 21, 2020
Merged

update Loggers #818

merged 2 commits into from
Feb 21, 2020

Conversation

Borda
Copy link
Member

@Borda Borda commented Feb 11, 2020

What does this PR do?

Update logger warnings...

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

@Borda Borda added the feature Is an improvement or enhancement label Feb 11, 2020
@Borda Borda added this to the 0.6.1 milestone Feb 11, 2020
@Borda Borda changed the title update Loggers update Loggers [wip] Feb 11, 2020
@Borda Borda changed the title update Loggers [wip] update Loggers Feb 19, 2020
@Borda
Copy link
Member Author

Borda commented Feb 19, 2020

the original default logger is dropped since we will support multiple loggers #825

@Borda Borda requested a review from a team February 19, 2020 16:43
@Borda Borda added the ready PRs ready to be merged label Feb 19, 2020
@williamFalcon
Copy link
Contributor

@Borda we need a default logger...

@williamFalcon williamFalcon merged commit f7e9700 into Lightning-AI:master Feb 21, 2020
@Borda Borda deleted the logger branch February 21, 2020 19:21
@Borda
Copy link
Member Author

Borda commented Feb 21, 2020

You mean TensorBoardLogger, right?

tullie pushed a commit to tullie/pytorch-lightning that referenced this pull request Apr 3, 2020
* add warnings

* fix link
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Is an improvement or enhancement ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants