Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the gradient_clip_algorithm has no effect issue. #6928

Merged
merged 8 commits into from
Apr 14, 2021
Merged

Fix the gradient_clip_algorithm has no effect issue. #6928

merged 8 commits into from
Apr 14, 2021

Commits on Apr 9, 2021

  1. An attempt to fix gradient_clip_algorithm problem (Lightning-AI#6920) 

    Also add a temporay workaround to Lightning-AI#6807
    @ceshine
    ceshine committed Apr 9, 2021
    Configuration menu
    Copy the full SHA
    8585071 View commit details
    Browse the repository at this point in the history

  2. Fix the PEP8 compliance issue

    @ceshine
    ceshine committed Apr 9, 2021
    Configuration menu
    Copy the full SHA
    17a198e View commit details
    Browse the repository at this point in the history

  3. Fix the mistake from rebasing

    @ceshine
    ceshine committed Apr 9, 2021
    Configuration menu
    Copy the full SHA
    338769a View commit details
    Browse the repository at this point in the history

  4. Revert changes regarding to Lightning-AI#6807

    @ceshine
    ceshine committed Apr 9, 2021
    Configuration menu
    Copy the full SHA
    bf1bd46 View commit details
    Browse the repository at this point in the history

  5. Remove an unused variable

    @ceshine
    ceshine committed Apr 9, 2021
    Configuration menu
    Copy the full SHA
    218ecec View commit details
    Browse the repository at this point in the history

  6. Expect the TPU test case to fail

    @ceshine
    ceshine committed Apr 9, 2021
    Configuration menu
    Copy the full SHA
    a3007ad View commit details
    Browse the repository at this point in the history

Commits on Apr 10, 2021

  1. Make the possibility of false positive even lower

    @ceshine
    ceshine committed Apr 10, 2021
    Configuration menu
    Copy the full SHA
    81cab3b View commit details
    Browse the repository at this point in the history

  2. Only train one step in test cases

    @ceshine
    ceshine committed Apr 10, 2021
    Configuration menu
    Copy the full SHA
    3d3f7cc View commit details
    Browse the repository at this point in the history