Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MetricsHolder clean-up + typing #6645

Merged
merged 3 commits into from
Mar 24, 2021
Merged

MetricsHolder clean-up + typing #6645

merged 3 commits into from
Mar 24, 2021

Conversation

carmocca
Copy link
Contributor

What does this PR do?

  • Improves typing
  • Adds better error message when the metric has more than one element + a test for it. Previous error was: ValueError: only one element tensors can be converted to Python scalars
  • Removes unused arguments
  • Simplifies conditions

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • [n/a] Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • [n/a] Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

@carmocca carmocca added this to the 1.3 milestone Mar 23, 2021
@carmocca carmocca self-assigned this Mar 23, 2021
@carmocca carmocca marked this pull request as ready for review March 23, 2021 00:57
@carmocca carmocca changed the title MetricsHolder clean-up + typing MetricsHolder clean-up + typing Mar 23, 2021
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@Borda Borda enabled auto-merge (squash) March 24, 2021 19:32
@Borda Borda merged commit 2dd6f9e into master Mar 24, 2021
@Borda Borda deleted the metrics-holder-cleanup branch March 24, 2021 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants