Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Sagemaker DDP Plugin #6271
Add Sagemaker DDP Plugin #6271
Changes from 10 commits
ad77ff2
270e4df
33c9891
0380efb
c115ece
50c045d
eab4f58
f233b1a
2e9280c
c91e9f2
a13a675
88b2b4b
ffc85ea
833bb57
467e76b
c2a508c
f5a2cf4
f5675e8
0dff5c7
eacf9a8
d1bf909
da66a19
fdaeb5b
01b2d37
af070e3
b7e5548
1373f8f
9817608
937b50c
c7c16ba
281231e
6c2f229
d514a6f
8605f81
1c4a315
4ac0c4e
9512dc4
13dac0b
e38fb37
7797770
4a0f78d
574887f
19fa542
5699a32
7a715a0
e43fc1b
1ac88a8
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add a small description on how to make this work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also add how to instal it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this something we maybe should extend the Environment class by?
cc @awaelchli
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's different in this function from the ddp plugin? Can we remove this and inherit it from the DDP Plugin
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The only difference is calling
self.set_world_ranks()
, as I am able to get it through the Environment methods using thesmdistributed
module. For eg.,dist.get_world_size()