-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wandb: Fix example rendering for docs #5905
Merged
carmocca
merged 40 commits into
Lightning-AI:master
from
EricCousineau-TRI:feature-minor-doc
Feb 16, 2021
Merged
wandb: Fix example rendering for docs #5905
carmocca
merged 40 commits into
Lightning-AI:master
from
EricCousineau-TRI:feature-minor-doc
Feb 16, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EricCousineau-TRI
requested review from
awaelchli,
Borda and
tchaton
as code owners
February 10, 2021 14:58
Codecov Report
@@ Coverage Diff @@
## master #5905 +/- ##
=======================================
- Coverage 90% 88% -3%
=======================================
Files 170 170
Lines 11784 11784
=======================================
- Hits 10664 10362 -302
- Misses 1120 1422 +302 |
carmocca
requested review from
ananyahjha93,
carmocca,
edenlightning,
justusschock,
SeanNaren,
SkafteNicki,
teddykoker and
williamFalcon
as code owners
February 10, 2021 15:14
carmocca
force-pushed
the
feature-minor-doc
branch
from
February 10, 2021 15:21
56469b5
to
8ab6e28
Compare
carmocca
approved these changes
Feb 10, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Changed the base branch since we have blocked commits to master until the 1.3 release
SkafteNicki
approved these changes
Feb 10, 2021
Borda
approved these changes
Feb 10, 2021
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
awaelchli
approved these changes
Feb 10, 2021
justusschock
approved these changes
Feb 11, 2021
auto-merge was automatically disabled
February 11, 2021 14:32
Base branch was modified
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes doc rendering bug.
Before:
https://pytorch-lightning.readthedocs.io/en/stable/generated/pytorch_lightning.loggers.WandbLogger.html#pytorch_lightning.loggers.WandbLogger
After (local rendering, no style):
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Lol, more or less. Was investigating stuff like #981 tho :(