Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename conflicting test directories #4451

Merged
merged 4 commits into from
Nov 2, 2020
Merged

Rename conflicting test directories #4451

merged 4 commits into from
Nov 2, 2020

Conversation

carmocca
Copy link
Contributor

What does this PR do?

See issue:
Fixes #4436

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together? Otherwise, we ask you to create a separate PR for every change.
  • [n/a] Did you make sure to update the documentation with your changes?
  • [n/a] Did you write any new necessary tests?
  • Did you verify new and existing tests pass locally with your changes?
  • [n/a] If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)

@codecov
Copy link

codecov bot commented Oct 30, 2020 •
edited
Loading

Codecov Report

Merging #4451 into master will increase coverage by 0%.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master   #4451   +/-   ##
======================================
  Coverage      93%     93%           
======================================
  Files         113     113           
  Lines        8222    8197   -25     
======================================
- Hits         7637    7621   -16     
+ Misses        585     576    -9

tchaton
tchaton approved these changes Nov 2, 2020
View reviewed changes
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contributions !

@ydcjeff ydcjeff added ci Continuous Integration feature Is an improvement or enhancement labels Nov 2, 2020
@ydcjeff ydcjeff added this to the 1.0.x milestone Nov 2, 2020
@rohitgr7 rohitgr7 merged commit 66ade19 into Lightning-AI:master Nov 2, 2020
Borda pushed a commit that referenced this pull request Nov 4, 2020
@carmocca @Borda
Rename conflicting test directories (#4451)
8a7a024 
* logging -> logging_tests

* warnings -> warnings_tests

Co-authored-by: Jeff Yang <ydcjeff@outlook.com>
Co-authored-by: Rohit Gupta <rohitgr1998@gmail.com>
(cherry picked from commit 66ade19)
@carmocca carmocca deleted the bug/rename-test-dirs branch November 9, 2020 01:25
rohitgr7 added a commit that referenced this pull request Nov 21, 2020
@carmocca @rohitgr7
Rename conflicting test directories (#4451)
1a64e6a 
* logging -> logging_tests

* warnings -> warnings_tests

Co-authored-by: Jeff Yang <ydcjeff@outlook.com>
Co-authored-by: Rohit Gupta <rohitgr1998@gmail.com>
@carmocca carmocca mentioned this pull request Jan 25, 2021
Merged
@carmocca carmocca self-assigned this Nov 1, 2023
@mergify mergify bot added the ready PRs ready to be merged label Nov 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tchaton tchaton tchaton approved these changes

@justusschock justusschock justusschock approved these changes

@rohitgr7 rohitgr7 rohitgr7 approved these changes

@ananyahjha93 ananyahjha93 Awaiting requested review from ananyahjha93

@awaelchli awaelchli Awaiting requested review from awaelchli

@Borda Borda Awaiting requested review from Borda Borda is a code owner

@nateraw nateraw Awaiting requested review from nateraw

@SeanNaren SeanNaren Awaiting requested review from SeanNaren

@teddykoker teddykoker Awaiting requested review from teddykoker

@williamFalcon williamFalcon Awaiting requested review from williamFalcon

Assignees

@carmocca carmocca

Labels
ci Continuous Integration feature Is an improvement or enhancement ready PRs ready to be merged
Projects
None yet
Milestone
pl:1.0.x
Development

Successfully merging this pull request may close these issues.

Some test directories clash with standard library modules
5 participants
@carmocca @tchaton @justusschock @rohitgr7 @ydcjeff