Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix misuse of transforms in docs #3546

Merged
merged 5 commits into from
Sep 18, 2020

Conversation

nateraw
Copy link
Contributor

@nateraw nateraw commented Sep 18, 2020

What does this PR do?

Docfix mentioned in #3461

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together? Otherwise, we ask you to create a separate PR for every change.
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@nateraw nateraw added bug Something isn't working docs Documentation related labels Sep 18, 2020
@mergify mergify bot requested a review from a team September 18, 2020 06:18
@codecov
Copy link

codecov bot commented Sep 18, 2020

Codecov Report

Merging #3546 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master   #3546   +/-   ##
======================================
  Coverage      91%     91%           
======================================
  Files         109     109           
  Lines        8043    8043           
======================================
  Hits         7303    7303           
  Misses        740     740           

@Borda Borda removed the bug Something isn't working label Sep 18, 2020
Copy link
Member

@Borda Borda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@mergify mergify bot requested a review from a team September 18, 2020 07:36
@Borda Borda added the ready PRs ready to be merged label Sep 18, 2020
@mergify mergify bot requested a review from a team September 18, 2020 09:49
Copy link
Contributor

@awaelchli awaelchli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for updating these docs!

docs/source/datamodules.rst Outdated Show resolved Hide resolved
Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>
@Borda Borda merged commit c46de8a into Lightning-AI:master Sep 18, 2020
@Borda Borda added this to the 0.9.x milestone Sep 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation related ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants