Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add num_classes argument to confusion matrix #3450

Merged
merged 3 commits into from
Sep 10, 2020
Merged

add num_classes argument to confusion matrix #3450

merged 3 commits into from
Sep 10, 2020

Conversation

c00k1ez
Copy link
Contributor

@c00k1ez c00k1ez commented Sep 10, 2020

What does this PR do?

Add num_classes argument to metrics.ConfusionMatrixand functional.confusion_matrix, update test_confusion_matrix() . Discussed this issue with @SkafteNicki in Slack.

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together? Otherwise, we ask you to create a separate PR for every change.
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@mergify mergify bot requested a review from a team September 10, 2020 16:44
@c00k1ez
Copy link
Contributor Author

c00k1ez commented Sep 10, 2020

@SkafteNicki Check this PR plz)

@codecov
Copy link

codecov bot commented Sep 10, 2020

Codecov Report

Merging #3450 into master will increase coverage by 0%.
The diff coverage is 97%.

@@          Coverage Diff           @@
##           master   #3450   +/-   ##
======================================
  Coverage      90%     90%           
======================================
  Files         103     104    +1     
  Lines        8112    8125   +13     
======================================
+ Hits         7295    7313   +18     
+ Misses        817     812    -5     

Copy link
Member

@SkafteNicki SkafteNicki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Very good job :]

@mergify mergify bot requested a review from a team September 10, 2020 17:47
@SkafteNicki SkafteNicki requested review from justusschock and removed request for a team September 10, 2020 17:48
@mergify mergify bot requested a review from a team September 10, 2020 17:48
@SkafteNicki SkafteNicki added Metrics feature Is an improvement or enhancement labels Sep 10, 2020
@mergify mergify bot requested a review from a team September 10, 2020 17:54
@Borda Borda added the ready PRs ready to be merged label Sep 10, 2020
@mergify mergify bot requested a review from a team September 10, 2020 21:00
@williamFalcon williamFalcon merged commit d05d4c7 into Lightning-AI:master Sep 10, 2020
@Borda Borda added this to the 0.9.x milestone Sep 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Is an improvement or enhancement ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants