ddp fix for trainer.test() + add basic ddp tests #2997
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2997 +/- ##
======================================
- Coverage 90% 90% -0%
======================================
Files 82 82
Lines 7628 7626 -2
======================================
- Hits 6862 6860 -2
Misses 766 766 |
Closed
awaelchli
added
bug
| @@ -893,10 +893,6 @@ def init_ddp_connection(self, global_rank: int, world_size: int, is_slurm_managi | |||
| log.info(f"initializing ddp: GLOBAL_RANK: {global_rank}, MEMBER: {global_rank+1}/{world_size}") | |||
| torch_distrib.init_process_group(torch_backend, rank=global_rank, world_size=world_size) | |||
|
|
|||
| """ | |||
There was a problem hiding this comment.
why did we remove this?
There was a problem hiding this comment.
It looks like it does not belong here. My question would be why is it here in the first place?
ameliatqy
pushed a commit
to ameliatqy/pytorch-lightning
that referenced
this pull request
Aug 17, 2020
* add ddp script variations * add ddp test * rename * shell * test * test * try call * try without subprocess * test * display the error * list all variations * try string * try copy env * debug * pythonpath * path * update test * change * simple ddp test * replace * remove random port * random port * str * clean up * check run spawn * clean up * docs * docs * update test * docs * changelog * changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #2683
Fixes #2765
Fixes #2807 (docs for clarification)
Fixes #2537 (docs for clarification)
(maybe also #2901)
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Nope, in this one definitely not! :(