Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Comet Logger pickled behavior #2553

Merged
merged 15 commits into from
Sep 18, 2020
Merged

Improve Comet Logger pickled behavior #2553

merged 15 commits into from
Sep 18, 2020

Commits on Jul 8, 2020

  1. Improve Comet Logger pickled behavior 

    * Delay the creation of the actual experiment object for as long as we can.
* Save the experiment id in case an Experiment object is created so we can
  continue the same experiment in the sub-processes.
* Run pre-commit on the comet file.
    @Lothiraldan
    Lothiraldan committed Jul 8, 2020
    Configuration menu
    Copy the full SHA
    a1d8713 View commit details
    Browse the repository at this point in the history

  2. Handle review comment 

    Make most Comet Logger attribute protected as they might not reflect the final
Experiment attributes. Also fix the typo in the test name.
    @Lothiraldan
    Lothiraldan committed Jul 8, 2020
    Configuration menu
    Copy the full SHA
    31073c2 View commit details
    Browse the repository at this point in the history

Commits on Jul 10, 2020

  1. Ensure that CometLogger.name and CometLogger.version always returns str

    @Lothiraldan
    Lothiraldan committed Jul 10, 2020
    Configuration menu
    Copy the full SHA
    7cfdd01 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into comet-logger-better-pickling

    @Lothiraldan
    Lothiraldan committed Jul 10, 2020
    Configuration menu
    Copy the full SHA
    05e6648 View commit details
    Browse the repository at this point in the history

  3. Add new test for CometLogger.version behavior

    @Lothiraldan
    Lothiraldan committed Jul 10, 2020
    Configuration menu
    Copy the full SHA
    4f016fa View commit details
    Browse the repository at this point in the history

Commits on Jul 15, 2020

  1. Add new tests for CometLogger.name and CometLogger.version

    @Lothiraldan
    Lothiraldan committed Jul 15, 2020
    Configuration menu
    Copy the full SHA
    f89691d View commit details
    Browse the repository at this point in the history

Commits on Jul 27, 2020

  1. Apply review suggestions

    @Lothiraldan
    Lothiraldan committed Jul 27, 2020
    Configuration menu
    Copy the full SHA
    c7d7b2d View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into comet-logger-better-pickling

    @Lothiraldan
    Lothiraldan committed Jul 27, 2020
    Configuration menu
    Copy the full SHA
    fc7e447 View commit details
    Browse the repository at this point in the history

Commits on Aug 3, 2020

  1. Merge branch 'master' into comet-logger-better-pickling

    @Lothiraldan
    Lothiraldan committed Aug 3, 2020
    Configuration menu
    Copy the full SHA
    181d6fa View commit details
    Browse the repository at this point in the history

Commits on Aug 7, 2020

  1. Merge branch 'master' into comet-logger-better-pickling

    @Lothiraldan
    Lothiraldan committed Aug 7, 2020
    Configuration menu
    Copy the full SHA
    ce5457a View commit details
    Browse the repository at this point in the history

Commits on Aug 19, 2020

  1. Apply suggestions from code review 

    Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
    @Lothiraldan @Borda
    Lothiraldan and Borda authored Aug 19, 2020
    Configuration menu
    Copy the full SHA
    ec30eb2 View commit details
    Browse the repository at this point in the history

  2. Remove extraneous comments in Comet logger tests

    @Lothiraldan
    Lothiraldan committed Aug 19, 2020
    Configuration menu
    Copy the full SHA
    eac4a18 View commit details
    Browse the repository at this point in the history

Commits on Sep 15, 2020

  1. Merge branch 'master' into comet-logger-better-pickling

    @Lothiraldan
    Lothiraldan authored Sep 15, 2020
    Configuration menu
    Copy the full SHA
    5b4939f View commit details
    Browse the repository at this point in the history

  2. Fix lint issues

    @Lothiraldan
    Lothiraldan committed Sep 15, 2020
    Configuration menu
    Copy the full SHA
    45e4cb1 View commit details
    Browse the repository at this point in the history

Commits on Sep 18, 2020

  1. Apply suggestions from code review 

    Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>
    @Lothiraldan @awaelchli
    Lothiraldan and awaelchli authored Sep 18, 2020
    Configuration menu
    Copy the full SHA
    8e38c62 View commit details
    Browse the repository at this point in the history