Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs & Changelog #2176

Merged
merged 7 commits into from
Jun 13, 2020
Merged

Docs & Changelog #2176

merged 7 commits into from
Jun 13, 2020

Conversation

Borda
Copy link
Member

@Borda Borda commented Jun 13, 2020

What does this PR do?

Fixes # (issue).

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@Borda Borda added the docs Documentation related label Jun 13, 2020
@Borda Borda added this to the 0.8.0 milestone Jun 13, 2020
@mergify mergify bot requested a review from a team June 13, 2020 16:36
@Borda Borda changed the title Missing Changelog [wip] Docs & Changelog Jun 13, 2020
@Borda Borda requested a review from awaelchli June 13, 2020 17:20
@Borda
Copy link
Member Author

Borda commented Jun 13, 2020

Fixes failing master...

@Borda Borda added bug Something isn't working priority: 0 High priority task labels Jun 13, 2020
@Borda Borda mentioned this pull request Jun 13, 2020
5 tasks
Copy link
Contributor

@awaelchli awaelchli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Borda thanks for adding the instructions :)

.github/CONTRIBUTING.md Outdated Show resolved Hide resolved
.github/CONTRIBUTING.md Show resolved Hide resolved
@mergify mergify bot requested a review from a team June 13, 2020 18:17
@codecov
Copy link

codecov bot commented Jun 13, 2020

Codecov Report

Merging #2176 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master   #2176   +/-   ##
======================================
  Coverage      87%     87%           
======================================
  Files          68      68           
  Lines        5180    5180           
======================================
  Hits         4508    4508           
  Misses        672     672           

Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>
@Borda Borda added the ready PRs ready to be merged label Jun 13, 2020
@Borda
Copy link
Member Author

Borda commented Jun 13, 2020

@williamFalcon can we merge this to fix master and so unblock all PRs... 🐰

@williamFalcon williamFalcon merged commit 206245e into master Jun 13, 2020
@Borda Borda deleted the docs/changelog branch June 14, 2020 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working docs Documentation related priority: 0 High priority task ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants