Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding DictConfig check in isinstance #2060

Closed
wants to merge 1 commit into from
Closed

Adding DictConfig check in isinstance #2060

wants to merge 1 commit into from

Conversation

ssakhavi
Copy link
Contributor

@ssakhavi ssakhavi commented Jun 3, 2020

Instead of checking only dict, adding the check for DictConfig so it can work with Hydra.

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

What does this PR do?

Fixes #2058.

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Instead of checking only `dict`, adding the check for `DictConfig` so it can work with Hydra.
@pep8speaks
Copy link

Hello @ssakhavi! Thanks for opening this PR.

Line 177:44: E231 missing whitespace after ','
Line 179:58: E231 missing whitespace after ','

Do see the Hitchhiker's guide to code style

@mergify mergify bot requested a review from a team June 3, 2020 10:08
@ssakhavi ssakhavi closed this Jun 3, 2020
@ssakhavi ssakhavi deleted the patch-1 branch June 3, 2020 10:11
@Borda
Copy link
Member

Borda commented Jun 3, 2020

@ssakhavi any special reason to close this PR? :]

@ssakhavi
Copy link
Contributor Author

ssakhavi commented Jun 3, 2020

I didn't add the test so I decided to delete the branch first, check where I need to add the test, and then add the pull request.

Now that I think, I should have just let it be and then add the tests later. Sorry.

Will you be able to delete the pull request and I can open a new one, @Borda

@Borda
Copy link
Member

Borda commented Jun 3, 2020

it is already deleted lol so send a new one when you feel ready :]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hydra MLFlow Clash
3 participants