code guideline #1949
Merged
code guideline #1949
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1949 +/- ##
======================================
Coverage 88% 88%
======================================
Files 74 74
Lines 4641 4641
======================================
Hits 4064 4064
Misses 577 577 |
justusschock
approved these changes
May 26, 2020
jeremyjordan
approved these changes
May 27, 2020
Co-authored-by: Jeremy Jordan <13970565+jeremyjordan@users.noreply.github.com>
|
This pull request is now in conflict... :( |
SkafteNicki
approved these changes
May 28, 2020
|
Great job! =) |
justusschock
pushed a commit
that referenced
this pull request
Jun 29, 2020
* code rule * Apply suggestions from code review Co-authored-by: Jeremy Jordan <13970565+jeremyjordan@users.noreply.github.com> * chlog Co-authored-by: Jeremy Jordan <13970565+jeremyjordan@users.noreply.github.com> Co-authored-by: Nicki Skafte <skaftenicki@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #1444 (comment)
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃