Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support TQDM_MINITERS env variable #19381

Merged
merged 3 commits into from
Feb 1, 2024
Merged

Conversation

wouterzwerink
Copy link
Contributor

@wouterzwerink wouterzwerink commented Jan 31, 2024

What does this PR do?

Fixes #19346

Before submitting
  • Was this discussed/agreed via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

Reviewer checklist
  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

📚 Documentation preview 📚: https://pytorch-lightning--19381.org.readthedocs.build/en/19381/

@github-actions github-actions bot added the pl Generic label for PyTorch Lightning package label Jan 31, 2024
Copy link

codecov bot commented Jan 31, 2024

Codecov Report

Merging #19381 (4cd09f7) into master (6421dd8) will decrease coverage by 35%.
Report is 1 commits behind head on master.
The diff coverage is 100%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #19381      +/-   ##
==========================================
- Coverage      84%      49%     -35%     
==========================================
  Files         448      440       -8     
  Lines       37885    37734     -151     
==========================================
- Hits        31647    18364   -13283     
- Misses       6238    19370   +13132     

@awaelchli awaelchli added feature Is an improvement or enhancement community This PR is from the community labels Jan 31, 2024
@awaelchli awaelchli added this to the 2.2 milestone Jan 31, 2024
@awaelchli
Copy link
Contributor

Thanks @wouterzwerink for making the pull request.
I pushed a unit test for good measure :)

@mergify mergify bot added the ready PRs ready to be merged label Feb 1, 2024
@awaelchli awaelchli merged commit 5d178d0 into Lightning-AI:master Feb 1, 2024
96 of 97 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community This PR is from the community feature Is an improvement or enhancement pl Generic label for PyTorch Lightning package progress bar: tqdm ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LitProgressBar ignores TQDM_MINITERS
3 participants