Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix porgressbar postfix order #1874

Merged

Conversation

asrafulashiq
Copy link
Contributor

@asrafulashiq asrafulashiq commented May 18, 2020

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

What does this PR do?

The items in progress_bar dict from training and validation is printed alphabetically in the tqdm output even when the dict is an OrderedDict, which is not an expected behavior. This PR fixes the issue.

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@mergify mergify bot requested a review from a team May 18, 2020 16:12
@williamFalcon williamFalcon merged commit e0a5aee into Lightning-AI:master May 19, 2020
@williamFalcon
Copy link
Contributor

Thank you @asrafulashiq

@Borda Borda added the bug Something isn't working label May 19, 2020
@Borda Borda added this to the 0.7.7 milestone May 19, 2020
@Borda Borda modified the milestones: 0.7.7, 0.8.0 May 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants