Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid flattening hyperparameters in WandbLogger #17574

Merged
merged 5 commits into from
May 5, 2023
Merged

Avoid flattening hyperparameters in WandbLogger #17574

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e34a2c1
avoid flattening dict in wanb
awaelchli May 5, 2023
992b043
update test
awaelchli May 5, 2023
76afb0c
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] May 5, 2023
3490fe2
add changelog
awaelchli May 5, 2023
bd05aa9
Merge remote-tracking branch 'origin/bugfix/wandb-sanitize' into bugf…
awaelchli May 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/lightning/pytorch/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,6 +104,9 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/).
- Fixed signature inspection of decorated hooks ([#17507](https://github.com/Lightning-AI/lightning/pull/17507))


- The `WandbLogger` no longer flattens dictionaries in the hyperparameters logged to the dashboard ([#17574](https://github.com/Lightning-AI/lightning/pull/17574))


## [2.0.1.post0] - 2023-04-11

### Fixed
Expand Down
3 changes: 1 addition & 2 deletions src/lightning/pytorch/loggers/wandb.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
from lightning_utilities.core.imports import RequirementCache
from torch import Tensor

from lightning.fabric.utilities.logger import _add_prefix, _convert_params, _flatten_dict, _sanitize_callable_params
from lightning.fabric.utilities.logger import _add_prefix, _convert_params, _sanitize_callable_params
from lightning.fabric.utilities.types import _PATH
from lightning.pytorch.callbacks.model_checkpoint import ModelCheckpoint
from lightning.pytorch.loggers.logger import Logger, rank_zero_experiment
Expand Down Expand Up @@ -418,7 +418,6 @@ def watch(self, model: nn.Module, log: str = "gradients", log_freq: int = 100, l
@rank_zero_only
def log_hyperparams(self, params: Union[Dict[str, Any], Namespace]) -> None:
params = _convert_params(params)
params = _flatten_dict(params)
params = _sanitize_callable_params(params)
self.experiment.config.update(params, allow_val_change=True)

Expand Down
7 changes: 3 additions & 4 deletions tests/tests_pytorch/loggers/test_wandb.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,10 +103,9 @@ def test_wandb_logger_init(wandb, monkeypatch):
wandb.init().log.assert_called_with({"acc": 1.0, "trainer/global_step": 6})

# log hyper parameters
logger.log_hyperparams({"test": None, "nested": {"a": 1}, "b": [2, 3, 4]})
wandb.init().config.update.assert_called_once_with(
{"test": None, "nested/a": 1, "b": [2, 3, 4]}, allow_val_change=True
)
hparams = {"test": None, "nested": {"a": 1}, "b": [2, 3, 4]}
logger.log_hyperparams(hparams)
wandb.init().config.update.assert_called_once_with(hparams, allow_val_change=True)

# watch a model
logger.watch("model", "log", 10, False)
Expand Down