Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove checks for torch greater than 1.10 #15846

Merged
merged 4 commits into from
Dec 1, 2022
Merged

Remove checks for torch greater than 1.10 #15846

merged 4 commits into from
Dec 1, 2022

Conversation

carmocca
Copy link
Contributor

@carmocca carmocca commented Nov 28, 2022 •
edited by github-actions bot
Loading

What does this PR do?

Follow-up to #15347

Does your PR introduce any breaking changes? If yes, please list them.

None

cc @Borda @justusschock @awaelchli

@carmocca carmocca added this to the v1.9 milestone Nov 28, 2022
@carmocca carmocca self-assigned this Nov 28, 2022
@carmocca carmocca added the pl Generic label for PyTorch Lightning package label Nov 28, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Nov 28, 2022 •
edited
Loading

⚡ Required checks status: All passing 🟢

Groups summary

🟢 pytorch_lightning: Tests workflow
Check ID Status
pl-cpu (macOS-11, pytorch, 3.8, 1.11) success ✅
pl-cpu (macOS-11, pytorch, 3.9, 1.12) success ✅
pl-cpu (macOS-11, pytorch, 3.10, 1.13) success ✅
pl-cpu (macOS-11, pytorch, 3.8, 1.10, oldest) success ✅
pl-cpu (ubuntu-20.04, pytorch, 3.8, 1.10) success ✅
pl-cpu (ubuntu-20.04, pytorch, 3.9, 1.11) success ✅
pl-cpu (ubuntu-20.04, pytorch, 3.10, 1.12) success ✅
pl-cpu (ubuntu-20.04, pytorch, 3.10, 1.13) success ✅
pl-cpu (ubuntu-20.04, pytorch, 3.7, 1.10, oldest) success ✅
pl-cpu (windows-2022, pytorch, 3.9, 1.11) success ✅
pl-cpu (windows-2022, pytorch, 3.10, 1.12) success ✅
pl-cpu (windows-2022, pytorch, 3.10, 1.13) success ✅
pl-cpu (windows-2022, pytorch, 3.7, 1.10, oldest) success ✅
pl-cpu (slow, macOS-11, pytorch, 3.7, 1.11) success ✅
pl-cpu (slow, ubuntu-20.04, pytorch, 3.7, 1.11) success ✅
pl-cpu (slow, windows-2022, pytorch, 3.7, 1.11) success ✅
pl-cpu (macOS-11, lightning, 3.8, 1.13) success ✅
pl-cpu (ubuntu-20.04, lightning, 3.8, 1.13) success ✅
pl-cpu (windows-2022, lightning, 3.8, 1.13) success ✅

These checks are required after the changes to src/lightning_lite/plugins/collectives/torch_collective.py, src/lightning_lite/plugins/precision/native_amp.py, src/lightning_lite/utilities/imports.py, src/pytorch_lightning/callbacks/quantization.py, src/pytorch_lightning/core/module.py, src/pytorch_lightning/plugins/precision/native_amp.py, src/pytorch_lightning/strategies/ddp.py, src/pytorch_lightning/utilities/__init__.py, src/pytorch_lightning/utilities/imports.py, tests/tests_pytorch/helpers/runif.py, tests/tests_pytorch/plugins/test_amp_plugins.py, tests/tests_pytorch/strategies/test_ddp_strategy.py, tests/tests_pytorch/strategies/test_ddp_strategy_with_comm_hook.py.

🟢 pytorch_lightning: Azure GPU
Check ID Status
pytorch-lightning (GPUs) success ✅

These checks are required after the changes to src/pytorch_lightning/callbacks/quantization.py, src/pytorch_lightning/core/module.py, src/pytorch_lightning/plugins/precision/native_amp.py, src/pytorch_lightning/strategies/ddp.py, src/pytorch_lightning/utilities/__init__.py, src/pytorch_lightning/utilities/imports.py, tests/tests_pytorch/helpers/runif.py, tests/tests_pytorch/plugins/test_amp_plugins.py, tests/tests_pytorch/strategies/test_ddp_strategy.py, tests/tests_pytorch/strategies/test_ddp_strategy_with_comm_hook.py, src/lightning_lite/plugins/collectives/torch_collective.py, src/lightning_lite/plugins/precision/native_amp.py, src/lightning_lite/utilities/imports.py.

🟢 pytorch_lightning: Azure HPU
Check ID Status
pytorch-lightning (HPUs) success ✅

These checks are required after the changes to src/lightning_lite/plugins/collectives/torch_collective.py, src/lightning_lite/plugins/precision/native_amp.py, src/lightning_lite/utilities/imports.py, src/pytorch_lightning/callbacks/quantization.py, src/pytorch_lightning/core/module.py, src/pytorch_lightning/plugins/precision/native_amp.py, src/pytorch_lightning/strategies/ddp.py, src/pytorch_lightning/utilities/__init__.py, src/pytorch_lightning/utilities/imports.py, tests/tests_pytorch/helpers/runif.py, tests/tests_pytorch/plugins/test_amp_plugins.py, tests/tests_pytorch/strategies/test_ddp_strategy.py, tests/tests_pytorch/strategies/test_ddp_strategy_with_comm_hook.py.

🟢 pytorch_lightning: Azure IPU
Check ID Status
pytorch-lightning (IPUs) success ✅

These checks are required after the changes to src/lightning_lite/plugins/collectives/torch_collective.py, src/lightning_lite/plugins/precision/native_amp.py, src/lightning_lite/utilities/imports.py, src/pytorch_lightning/callbacks/quantization.py, src/pytorch_lightning/core/module.py, src/pytorch_lightning/plugins/precision/native_amp.py, src/pytorch_lightning/strategies/ddp.py, src/pytorch_lightning/utilities/__init__.py, src/pytorch_lightning/utilities/imports.py, tests/tests_pytorch/helpers/runif.py, tests/tests_pytorch/plugins/test_amp_plugins.py, tests/tests_pytorch/strategies/test_ddp_strategy.py, tests/tests_pytorch/strategies/test_ddp_strategy_with_comm_hook.py.

🟢 pytorch_lightning: Docs
Check ID Status
make-doctest (pytorch) success ✅
make-html (pytorch) success ✅

These checks are required after the changes to src/pytorch_lightning/callbacks/quantization.py, src/pytorch_lightning/core/module.py, src/pytorch_lightning/plugins/precision/native_amp.py, src/pytorch_lightning/strategies/ddp.py, src/pytorch_lightning/utilities/__init__.py, src/pytorch_lightning/utilities/imports.py, docs/source-pytorch/advanced/model_parallel.rst, docs/source-pytorch/common/precision_intermediate.rst, docs/source-pytorch/conf.py.

🟢 lightning_lite: CPU workflow
Check ID Status
lite-cpu (macOS-11, lite, 3.8, 1.11) success ✅
lite-cpu (macOS-11, lite, 3.9, 1.12) success ✅
lite-cpu (macOS-11, lite, 3.10, 1.13) success ✅
lite-cpu (macOS-11, lite, 3.7, 1.10, oldest) success ✅
lite-cpu (ubuntu-20.04, lite, 3.8, 1.10) success ✅
lite-cpu (ubuntu-20.04, lite, 3.9, 1.11) success ✅
lite-cpu (ubuntu-20.04, lite, 3.10, 1.12) success ✅
lite-cpu (ubuntu-20.04, lite, 3.10, 1.13) success ✅
lite-cpu (ubuntu-20.04, lite, 3.7, 1.10, oldest) success ✅
lite-cpu (windows-2022, lite, 3.9, 1.11) success ✅
lite-cpu (windows-2022, lite, 3.10, 1.12) success ✅
lite-cpu (windows-2022, lite, 3.10, 1.13) success ✅
lite-cpu (windows-2022, lite, 3.7, 1.10, oldest) success ✅
lite-cpu (macOS-11, lightning, 3.8, 1.13) success ✅
lite-cpu (ubuntu-20.04, lightning, 3.8, 1.13) success ✅
lite-cpu (windows-2022, lightning, 3.8, 1.13) success ✅

These checks are required after the changes to src/lightning_lite/plugins/collectives/torch_collective.py, src/lightning_lite/plugins/precision/native_amp.py, src/lightning_lite/utilities/imports.py, tests/tests_lite/helpers/runif.py, tests/tests_lite/plugins/precision/test_native_amp.py, tests/tests_lite/test_connector.py.

🟢 lightning_lite: Azure GPU
Check ID Status
lightning-lite (GPUs) success ✅

These checks are required after the changes to src/lightning_lite/plugins/collectives/torch_collective.py, src/lightning_lite/plugins/precision/native_amp.py, src/lightning_lite/utilities/imports.py, tests/tests_lite/helpers/runif.py, tests/tests_lite/plugins/precision/test_native_amp.py, tests/tests_lite/test_connector.py.

🟢 mypy
Check ID Status
mypy success ✅

These checks are required after the changes to src/lightning_lite/plugins/collectives/torch_collective.py, src/lightning_lite/plugins/precision/native_amp.py, src/lightning_lite/utilities/imports.py, src/pytorch_lightning/callbacks/quantization.py, src/pytorch_lightning/core/module.py, src/pytorch_lightning/plugins/precision/native_amp.py, src/pytorch_lightning/strategies/ddp.py, src/pytorch_lightning/utilities/__init__.py, src/pytorch_lightning/utilities/imports.py.

🟢 install
Check ID Status
install-pkg (ubuntu-22.04, app, 3.7) success ✅
install-pkg (ubuntu-22.04, app, 3.10) success ✅
install-pkg (ubuntu-22.04, lite, 3.7) success ✅
install-pkg (ubuntu-22.04, lite, 3.10) success ✅
install-pkg (ubuntu-22.04, pytorch, 3.7) success ✅
install-pkg (ubuntu-22.04, pytorch, 3.10) success ✅
install-pkg (ubuntu-22.04, lightning, 3.7) success ✅
install-pkg (ubuntu-22.04, lightning, 3.10) success ✅
install-pkg (macOS-12, app, 3.7) success ✅
install-pkg (macOS-12, app, 3.10) success ✅
install-pkg (macOS-12, lite, 3.7) success ✅
install-pkg (macOS-12, lite, 3.10) success ✅
install-pkg (macOS-12, pytorch, 3.7) success ✅
install-pkg (macOS-12, pytorch, 3.10) success ✅
install-pkg (macOS-12, lightning, 3.7) success ✅
install-pkg (macOS-12, lightning, 3.10) success ✅
install-pkg (windows-2022, app, 3.7) success ✅
install-pkg (windows-2022, app, 3.10) success ✅
install-pkg (windows-2022, lite, 3.7) success ✅
install-pkg (windows-2022, lite, 3.10) success ✅
install-pkg (windows-2022, pytorch, 3.7) success ✅
install-pkg (windows-2022, pytorch, 3.10) success ✅
install-pkg (windows-2022, lightning, 3.7) success ✅
install-pkg (windows-2022, lightning, 3.10) success ✅

These checks are required after the changes to src/lightning_lite/plugins/collectives/torch_collective.py, src/lightning_lite/plugins/precision/native_amp.py, src/lightning_lite/utilities/imports.py, src/pytorch_lightning/callbacks/quantization.py, src/pytorch_lightning/core/module.py, src/pytorch_lightning/plugins/precision/native_amp.py, src/pytorch_lightning/strategies/ddp.py, src/pytorch_lightning/utilities/__init__.py, src/pytorch_lightning/utilities/imports.py.

Thank you for your contribution! 💜

Note
This comment is automatically generated and updates for 60 minutes every 180 seconds. If you have any other questions, contact carmocca for help.

@mergify mergify bot added the ready PRs ready to be merged label Nov 28, 2022
@carmocca carmocca merged commit 1bc3a97 into master Dec 1, 2022
@carmocca carmocca deleted the cleanup/remove-torch-gt-1.10 branch December 1, 2022 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@awaelchli awaelchli awaelchli approved these changes

@Borda Borda Borda approved these changes

@justusschock justusschock Awaiting requested review from justusschock justusschock is a code owner

@williamFalcon williamFalcon Awaiting requested review from williamFalcon

@tchaton tchaton Awaiting requested review from tchaton tchaton is a code owner

@edenlightning edenlightning Awaiting requested review from edenlightning

Assignees

@carmocca carmocca

Labels
pl Generic label for PyTorch Lightning package ready PRs ready to be merged refactor
Projects
None yet
Milestone
v1.9
Development

Successfully merging this pull request may close these issues.
3 participants
@carmocca @awaelchli @Borda