Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update auto_scale_batch_size error message and docstring with LightningDataModule #15351

Merged
merged 3 commits into from
Oct 28, 2022

Conversation

PaulLerner
Copy link
Contributor

What does this PR do?

Fixes #15276

Does your PR introduce any breaking changes? If yes, please list them.

No

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

cc @awaelchli I guess :)
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@github-actions github-actions bot added the pl Generic label for PyTorch Lightning package label Oct 27, 2022
@awaelchli awaelchli added docs Documentation related community This PR is from the community labels Oct 27, 2022
@awaelchli awaelchli modified the milestones: v1.8, v1.9 Oct 27, 2022
@mergify mergify bot added the ready PRs ready to be merged label Oct 27, 2022
@awaelchli awaelchli enabled auto-merge (squash) October 27, 2022 13:14
@awaelchli awaelchli changed the title docs: update auto_scale_batch_size error message and docstring with LightningDataModule. closes #15276 Update auto_scale_batch_size error message and docstring with LightningDataModule Oct 27, 2022
@awaelchli awaelchli merged commit 6b0b6b8 into Lightning-AI:master Oct 28, 2022
@carmocca carmocca modified the milestones: v1.9, v1.8 Oct 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community This PR is from the community docs Documentation related pl Generic label for PyTorch Lightning package ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make auto_scale_batch_size error message more informative
4 participants