Suppress Apex deprecation message #15071
Conversation
awaelchli
added
priority: 0
|
The previous warning filter did not work, I need to experiment. |
|
@awaelchli the issue is here https://github.com/Lightning-AI/lightning/blob/6f16e46bdb397bf1898e4d7d9050492924177abd/setup.cfg#L36 , since The warning is silenced when not run in pytest, but pytest filter takes precedence. I think we can decide to filter this particular inside every test that uses it. |
|
@otaj Thank you! So the filter works on the user side, that's what we want. Great! |
| from apex import amp | ||
|
|
||
| # TODO: Remove with deprecation of Apex integration #14416 | ||
| if hasattr(apex, "DeprecatedFeatureWarning"): |
There was a problem hiding this comment.
I wouldn't silence the warning at the source level. We want to appear to users IMO
We can only silence it during pytest time
There was a problem hiding this comment.
We would of course add our own deprecation in #14416. But we don't want two deprecation messages at the same time. Also, the apex message does not tell Lightning users that they can switch to precision=16 or precision=bf16
There was a problem hiding this comment.
Sure, but we haven't added our deprecation yet. So I would only replace it once we have ours
What does this PR do?
Fixes #15070
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
I made sure I had fun coding 🙃
cc @Borda @tchaton @rohitgr7 @carmocca @justusschock @awaelchli @akihironitta