Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Mixing hparams and arguments in LightningModule #1505

Merged
merged 9 commits into from
Apr 19, 2020
Merged

Fix Mixing hparams and arguments in LightningModule #1505

merged 9 commits into from
Apr 19, 2020

Commits on Apr 16, 2020

  1. Attempt to fix Lightning-AI#1468

    @HenryJia
    HenryJia committed Apr 16, 2020
    Configuration menu
    Copy the full SHA
    181b053 View commit details
    Browse the repository at this point in the history

  2. Remove the if statement, it doesn't actually make any difference

    @HenryJia
    HenryJia committed Apr 16, 2020
    Configuration menu
    Copy the full SHA
    8603508 View commit details
    Browse the repository at this point in the history

  3. Update docs

    @HenryJia
    HenryJia committed Apr 16, 2020
    Configuration menu
    Copy the full SHA
    7ffa62d View commit details
    Browse the repository at this point in the history

  4. Correct warnings I caused in the last commit

    @HenryJia
    HenryJia committed Apr 16, 2020
    Configuration menu
    Copy the full SHA
    d16a5e2 View commit details
    Browse the repository at this point in the history

Commits on Apr 17, 2020

  1. Add to changelog

    @HenryJia
    HenryJia committed Apr 17, 2020
    Configuration menu
    Copy the full SHA
    c01158f View commit details
    Browse the repository at this point in the history

  2. Actually add to changelog

    @HenryJia
    HenryJia committed Apr 17, 2020
    Configuration menu
    Copy the full SHA
    52d2eec View commit details
    Browse the repository at this point in the history

  3. Resolve merge conflicts

    @HenryJia
    HenryJia committed Apr 17, 2020
    Configuration menu
    Copy the full SHA
    1528fa0 View commit details
    Browse the repository at this point in the history

Commits on Apr 18, 2020

  1. Clarify documentation and examples

    @HenryJia
    HenryJia committed Apr 18, 2020
    Configuration menu
    Copy the full SHA
    298911b View commit details
    Browse the repository at this point in the history

Commits on Apr 19, 2020

  1. Update CHANGELOG.md

    @Borda
    Borda authored Apr 19, 2020
    Configuration menu
    Copy the full SHA
    9b1a1f8 View commit details
    Browse the repository at this point in the history